This repository was archived by the owner on Aug 4, 2026. It is now read-only.
chore(deps): upgrade @conduction/nextcloud-vue to 3.0.0-vue3.4 - #82
Open
rubenvdlinde wants to merge 1 commit into
Open
chore(deps): upgrade @conduction/nextcloud-vue to 3.0.0-vue3.4#82rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Bumps the shared Conduction Nextcloud Vue library from 2.1.0-vue3.17 to 3.0.0-vue3.4 (exact pin, no range). The 3.0.0 line removes three components: CnFlowCanvas, CnEditFlowsModal and CnFlowCanvasModal. deskdesk references none of them in src/ or in the built bundle, so no source changes are required. vue3-apexcharts stays pinned at 1.8.0 (below the proprietary 1.9.0 line).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
@conduction/nextcloud-vuefrom 2.1.0-vue3.17 to 3.0.0-vue3.4 (exact pin, no caret/tilde).Only
package.jsonandpackage-lock.jsonchange — no source changes were required.Lockfile verification
Verified from
package-lock.json(notpackage.json, notnpm ls):@conduction/nextcloud-vue3.0.0-vue3.4nextcloud-vue-3.0.0-vue3.4.tgzvue3-apexcharts1.8.0license: MIT, no override neededapexcharts4.7.0Lockfile sanity: 1133 package entries / 563 KB, versus 1133 entries on the base SHA — no silent under-resolution (e.g. a
//key insideoverridesmaking npm resolve zero deps while reporting "up to date").Regeneration sequence:
rm -rf package-lock.json node_modules→ npm 11.13.0npm install→ npm 10.9.8npm install --package-lock-only→ npm 10.9.8npm ci.Breaking surface — 3.0.0 removed 3 components
CnFlowCanvas,CnEditFlowsModal,CnFlowCanvasModal— zero occurrences insrc/and in builtjs/.Control 1 — greps demonstrably match (not false zeros):
src/js/CnFlowCanvasCnEditFlowsModalCnFlowCanvasModalCnDetailPage(retained)CnDashboardPage(retained)CnFlowEditModal(retained)Cn(any)ZZQQXX(nonexistent)Control 2 — removed-vs-retained confirmed against the installed library (
node_modules/@conduction/nextcloud-vue/dist/esm/index.js):CnFlowEditModal→ present (retained)CnDetailPage→ present (retained)CnFlowCanvas/CnEditFlowsModal/CnFlowCanvasModal→ absent (removed in 3.0.0)So the distinction is real in the shipped library, and the bundle greps can distinguish a present symbol from an absent one.
Local gates
USE_LOCAL_LIB=false npm run buildnpm run lint(eslint)jsdoc/require-paramwarnings, 0 errors)npm run stylelintnpm run test:e2e(Playwright)tests/)webpack.config.jscontains noUSE_LOCAL_LIBreference, so deskdesk does not alias a siblingnextcloud-vuecheckout; the env var was set anyway and is a no-op here.js/is gitignored and not committed.