Skip to content
This repository was archived by the owner on Aug 4, 2026. It is now read-only.

fix(ci): commit docs/features.json so Features Check passes - #81

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/features-json-drift
Aug 3, 2026
Merged

fix(ci): commit docs/features.json so Features Check passes#81
rubenvdlinde merged 1 commit into
developmentfrom
fix/features-json-drift

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Problem

quality / Features Check has failed on every pull request because docs/features.json was never committed at all — it is not tracked in git.

deskdesk has no capability specs yet (openspec/specs/ contains only README.md, and there is no spec.md anywhere in the tree), so the generator's correct output is an empty array.

Why it never self-healed

The push-side Features Extract job regenerates the file and tries to auto-commit it, but the push is rejected:

! [remote rejected] development -> development (push declined due to repository rule violations)

That failure is swallowed by git push || echo "::warning::...", so the job still reports success while doing nothing. Tracked as ConductionNL/.github#61. Until that is fixed, docs/features.json must be regenerated and committed by hand — including as soon as real specs land here.

The fix

Generated with scripts/extract-features.py from ConductionNL/.github@main and committed. No generator changes, no gate disabled, no threshold relaxed.

Verification

  • Reproduced the exact CI error locally at the same SHA (72f5668d): docs/features.json is out of date, exit 1.
  • After generation --check exits 0.
  • Positive control: replacing the file with a bogus one-entry array makes --check exit 1 again, and regenerating returns exit 0 — proving the checker still reports rather than trivially passing on an empty file.

Same root cause is fixed in parallel for nldesign; nextcloud-app-template shows the identical error and is affected too.

'quality / Features Check' has failed on every pull request because
docs/features.json was never committed at all. deskdesk has no capability
specs yet (openspec/specs/ contains only README.md), so the generator's
correct output is an empty array.

It never self-healed because the push-side 'Features Extract' job cannot
land its auto-commit on development:

    ! [remote rejected] development -> development
      (push declined due to repository rule violations)

That push failure is swallowed by a '|| echo ::warning' so the job still
reports success (ConductionNL/.github#61).

Generated with scripts/extract-features.py from ConductionNL/.github@main;
--check now exits 0. The file will need regenerating again as soon as real
specs land, until #61 is fixed.
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/deskdesk @ 172f080

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 100/100
npm ✅ 651/651
PHPUnit
Newman
Playwright ⏭️

Coverage: 0% (0/3 statements)


Quality workflow — 2026-08-03 14:11 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 52b15be into development Aug 3, 2026
30 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants