This repository was archived by the owner on Aug 4, 2026. It is now read-only.
fix(ci): commit docs/features.json so Features Check passes - #81
Merged
Conversation
'quality / Features Check' has failed on every pull request because
docs/features.json was never committed at all. deskdesk has no capability
specs yet (openspec/specs/ contains only README.md), so the generator's
correct output is an empty array.
It never self-healed because the push-side 'Features Extract' job cannot
land its auto-commit on development:
! [remote rejected] development -> development
(push declined due to repository rule violations)
That push failure is swallowed by a '|| echo ::warning' so the job still
reports success (ConductionNL/.github#61).
Generated with scripts/extract-features.py from ConductionNL/.github@main;
--check now exits 0. The file will need regenerating again as soon as real
specs land, until #61 is fixed.
Contributor
Quality Report — ConductionNL/deskdesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 651/651 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-08-03 14:11 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
quality / Features Checkhas failed on every pull request becausedocs/features.jsonwas never committed at all — it is not tracked in git.deskdesk has no capability specs yet (
openspec/specs/contains onlyREADME.md, and there is nospec.mdanywhere in the tree), so the generator's correct output is an empty array.Why it never self-healed
The push-side
Features Extractjob regenerates the file and tries to auto-commit it, but the push is rejected:That failure is swallowed by
git push || echo "::warning::...", so the job still reports success while doing nothing. Tracked as ConductionNL/.github#61. Until that is fixed,docs/features.jsonmust be regenerated and committed by hand — including as soon as real specs land here.The fix
Generated with
scripts/extract-features.pyfromConductionNL/.github@mainand committed. No generator changes, no gate disabled, no threshold relaxed.Verification
72f5668d):docs/features.json is out of date, exit 1.--checkexits 0.--checkexit 1 again, and regenerating returns exit 0 — proving the checker still reports rather than trivially passing on an empty file.Same root cause is fixed in parallel for nldesign; nextcloud-app-template shows the identical error and is affected too.