This repository was archived by the owner on Aug 4, 2026. It is now read-only.
chore: sync canonical root configs + mechanical phpmd cleanup - #33
Merged
Merged
Conversation
Phase 2 fleet-wide rollout: align deskdesk's PHP quality-tooling config with the nextcloud-app-template canonical (sibling PRs: shillinq#300, decidesk#243). Synced from /tmp/canonical/ → nextcloud-app-template: - phpcs.xml, phpmd.xml, psalm.xml, phpstan.neon, phpstan-bootstrap.php - phpcs-custom-sniffs/ (SpecTagSniff + NoLegacyServerAccessorsSniff) Cosmetic naming applied to phpcs.xml/phpmd.xml only (Deskdesk vs AppTemplate). No per-app rule weakening. Mechanical phpmd fix in source: - lib/Service/SettingsService.php: ElseExpression → two-if pattern (path-relative resolution in loadConfiguration()). phpstan baselined (1 entry, tracked in #32): - \OC::$SERVERROOT legacy server-accessor in SettingsService::244. Deferred to #32 (architectural, public API): - BooleanArgumentFlag on SettingsService::loadConfiguration($force). Final quality-gate counts: - phpcs: 0 errors, 21 warnings - phpstan: OK (1 baselined) - psalm: no errors - phpmd: 1 deferred (architectural)
Contributor
Quality Report — ConductionNL/deskdesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-21 20:35 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 fleet-wide rollout of canonical PHP quality-tooling configs from
nextcloud-app-template. Sibling PRs already merged on shillinq (#300)and decidesk (#243).
phpcs.xml,phpmd.xml,psalm.xml,phpstan.neon,phpstan-bootstrap.php, plus thephpcs-custom-sniffs/ruleset (SpecTagSniff, NoLegacyServerAccessorsSniff).phpcs.xmlandphpmd.xmlonly (Deskdesk vsAppTemplate). No per-app rule weakening.
SettingsService::loadConfiguration—if/elserefactored to two-if pattern (ElseExpression).phpstan-baseline.neongenerated with 1 entry:\OC::$SERVERROOTlegacy server-accessor in
SettingsService::244.Lint debt cleanup post-canonical-sync (Phase 2 fleet rollout) #32.
Final quality-gate counts
Test plan
phpcs --standard=phpcs.xml— 0 errorsphpstan analyse— OKpsalm— no errorsphpmd lib text phpmd.xml— only the public-API BooleanArgumentFlag (deferred)🤖 Generated with Claude Code