Skip to content
This repository was archived by the owner on Aug 4, 2026. It is now read-only.

chore(deps,manifest): refresh to nc-vue ^1.0.0-beta.66 + manifest v2 - #31

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/manifest-v2-and-lib-refresh
May 21, 2026
Merged

chore(deps,manifest): refresh to nc-vue ^1.0.0-beta.66 + manifest v2#31
rubenvdlinde merged 1 commit into
developmentfrom
chore/manifest-v2-and-lib-refresh

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Summary

DeskDesk is the academy tutorial reference app — it had drifted to pre-1.0 (^0.1.0-beta.7) and v1 manifest while the rest of the fleet moved to manifest v2. This brings it current so the academy tutorials' code examples match what readers see when they actually build the app.

  • Bumps @conduction/nextcloud-vue ^0.1.0-beta.7 -> ^1.0.0-beta.66
  • Aligns @nextcloud/axios (~2.5.2), @nextcloud/l10n (3.4.1), @nextcloud/router (^3.1.0) with the fleet's known-good versions; adds matching overrides[] to pin peer-dep resolution
  • Adds babel-loader devDep (^10.1.1) — required by webpack-vue-config but missing from the v1 lockfile, masked by the old nc-vue install
  • Migrates src/manifest.json v1 -> v2:
    • $schema URL flipped to app-manifest-v2.schema.json
    • version bumped to 2.0.0
    • top-level id/title dropped (v2 schema rejects them via additionalProperties:false; appId is hardcoded in App.vue, manifest title was unused)
    • desks-detail keeps its rich sidebar.tabs (data + knowledge + metadata) — v2 carries this v1.3.0 shape forward, and the KnowledgeTab custom component stays wired via the cnCustomComponents registry
    • bookings-detail + floors-detail get config.sidebar: true so the lib's built-in CnObjectSidebar mounts (Files/Notes/Tags/Tasks/Audit Trail tabs)

Academy heads-up

The manifest's overall page structure is unchanged (3 menus, 6 pages, same routes, same ids). What changed at the source level:

  • Top-level id/title fields removed (v2 schema disallows them)
  • bookings-detail + floors-detail now declare config.sidebar: true (one new line each)
  • $schema URL and version value updated

Tutorials 1-5 should still build the manifest more or less as written, but if a tutorial code snippet pins manifest.id or shows the v1 $schema URL, an academy follow-up will want to refresh those snippets.

Test plan

  • npm install --legacy-peer-deps --min-release-age=0 clean
  • Manifest passes ajv validation against app-manifest-v2.schema.json
  • npm run build green (webpack 5, 0 errors, 4 warnings — asset-size + unrelated floating-vue/getScrollParents peer warnings, both pre-existing across the fleet)
  • Manual smoke against a dev Nextcloud (deferred; CI on PR will exercise the build path)

…fest to v2

DeskDesk is the academy tutorial reference app — it had drifted to
pre-1.0 (^0.1.0-beta.7) and v1 manifest while the rest of the fleet
moved to manifest v2. This brings it current so academy tutorials'
code examples match what readers see when they actually build the app.

- Bumps @conduction/nextcloud-vue ^0.1.0-beta.7 -> ^1.0.0-beta.66
- Aligns @nextcloud/axios (~2.5.2), @nextcloud/l10n (3.4.1),
  @nextcloud/router (^3.1.0) with the fleet's known-good versions;
  adds matching overrides[] to pin peer-dep resolution
- Adds babel-loader devDep (^10.1.1) — required by webpack-vue-config
  but missing from the v1 lockfile, masked by the old nc-vue install
- Migrates src/manifest.json v1 -> v2:
    * $schema URL flipped to app-manifest-v2.schema.json
    * version bumped to 2.0.0
    * top-level id/title dropped (v2 schema rejects them via
      additionalProperties:false; appId is hardcoded in App.vue,
      manifest title was unused)
    * desks-detail keeps its rich sidebar.tabs (data + knowledge +
      metadata) — v2 carries this v1.3.0 shape forward, and the
      KnowledgeTab custom component stays wired via the
      cnCustomComponents registry
    * bookings-detail + floors-detail get config.sidebar:true so the
      lib's built-in CnObjectSidebar mounts (Files/Notes/Tags/Tasks/
      Audit Trail tabs)

Smoke build green (webpack 5.106.2, 0 errors, 4 warnings — asset-size
+ unrelated floating-vue/getScrollParents peer warnings); manifest
passes ajv validation against the v2 schema.
@rubenvdlinde
rubenvdlinde merged commit f0085c9 into development May 21, 2026
14 checks passed
@rubenvdlinde
rubenvdlinde deleted the chore/manifest-v2-and-lib-refresh branch May 21, 2026 10:05
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/deskdesk @ 64ac9ed

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 100/100
npm ✅ 591/591
PHPUnit
Newman
Playwright ⏭️

Coverage: 0% (0/3 statements)


Quality workflow — 2026-05-21 10:08 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant