This repository was archived by the owner on Aug 4, 2026. It is now read-only.
chore(deps,manifest): refresh to nc-vue ^1.0.0-beta.66 + manifest v2 - #31
Merged
Merged
Conversation
…fest to v2
DeskDesk is the academy tutorial reference app — it had drifted to
pre-1.0 (^0.1.0-beta.7) and v1 manifest while the rest of the fleet
moved to manifest v2. This brings it current so academy tutorials'
code examples match what readers see when they actually build the app.
- Bumps @conduction/nextcloud-vue ^0.1.0-beta.7 -> ^1.0.0-beta.66
- Aligns @nextcloud/axios (~2.5.2), @nextcloud/l10n (3.4.1),
@nextcloud/router (^3.1.0) with the fleet's known-good versions;
adds matching overrides[] to pin peer-dep resolution
- Adds babel-loader devDep (^10.1.1) — required by webpack-vue-config
but missing from the v1 lockfile, masked by the old nc-vue install
- Migrates src/manifest.json v1 -> v2:
* $schema URL flipped to app-manifest-v2.schema.json
* version bumped to 2.0.0
* top-level id/title dropped (v2 schema rejects them via
additionalProperties:false; appId is hardcoded in App.vue,
manifest title was unused)
* desks-detail keeps its rich sidebar.tabs (data + knowledge +
metadata) — v2 carries this v1.3.0 shape forward, and the
KnowledgeTab custom component stays wired via the
cnCustomComponents registry
* bookings-detail + floors-detail get config.sidebar:true so the
lib's built-in CnObjectSidebar mounts (Files/Notes/Tags/Tasks/
Audit Trail tabs)
Smoke build green (webpack 5.106.2, 0 errors, 4 warnings — asset-size
+ unrelated floating-vue/getScrollParents peer warnings); manifest
passes ajv validation against the v2 schema.
Contributor
Quality Report — ConductionNL/deskdesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-21 10:08 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeskDesk is the academy tutorial reference app — it had drifted to pre-1.0 (
^0.1.0-beta.7) and v1 manifest while the rest of the fleet moved to manifest v2. This brings it current so the academy tutorials' code examples match what readers see when they actually build the app.@conduction/nextcloud-vue^0.1.0-beta.7->^1.0.0-beta.66@nextcloud/axios(~2.5.2),@nextcloud/l10n(3.4.1),@nextcloud/router(^3.1.0) with the fleet's known-good versions; adds matchingoverrides[]to pin peer-dep resolutionbabel-loaderdevDep (^10.1.1) — required bywebpack-vue-configbut missing from the v1 lockfile, masked by the old nc-vue installsrc/manifest.jsonv1 -> v2:$schemaURL flipped toapp-manifest-v2.schema.jsonversionbumped to2.0.0id/titledropped (v2 schema rejects them viaadditionalProperties:false;appIdis hardcoded inApp.vue, manifest title was unused)desks-detailkeeps its richsidebar.tabs(data + knowledge + metadata) — v2 carries this v1.3.0 shape forward, and theKnowledgeTabcustom component stays wired via thecnCustomComponentsregistrybookings-detail+floors-detailgetconfig.sidebar: trueso the lib's built-inCnObjectSidebarmounts (Files/Notes/Tags/Tasks/Audit Trail tabs)Academy heads-up
The manifest's overall page structure is unchanged (3 menus, 6 pages, same routes, same ids). What changed at the source level:
id/titlefields removed (v2 schema disallows them)bookings-detail+floors-detailnow declareconfig.sidebar: true(one new line each)$schemaURL andversionvalue updatedTutorials 1-5 should still build the manifest more or less as written, but if a tutorial code snippet pins
manifest.idor shows the v1$schemaURL, an academy follow-up will want to refresh those snippets.Test plan
npm install --legacy-peer-deps --min-release-age=0cleanapp-manifest-v2.schema.jsonnpm run buildgreen (webpack 5, 0 errors, 4 warnings — asset-size + unrelated floating-vue/getScrollParents peer warnings, both pre-existing across the fleet)