This repository was archived by the owner on Aug 4, 2026. It is now read-only.
feat(part-2): schemas + manifest + CnAppRoot - #2
Merged
Conversation
Part 2 of the DeskDesk tutorial wires the empty Part 1 shell to real
data via OpenRegister + the @conduction/nextcloud-vue manifest renderer.
Schemas (lib/Settings/deskdesk_register.json):
- floor label + building + planImage
- desk label + floor (relation) + zone + equipment[] + capacity +
accessibility + photo + notes
- booking desk (relation) + user + start + end + purpose + status +
recurrence
Plus a components.registers.deskdesk block + 5 desk / 2 floor / 3
booking seed objects so the app is demoable on first install.
Manifest (src/manifest.json):
- Three top-level menu entries (Desks / Bookings / Floors), order 10/20/30
- Pages for index + detail of each schema, dispatched by CnPageRenderer
by matching $route.name === page.id
- dependencies: ['openregister'] so CnAppRoot's dependency-check phase
fires when OpenRegister is missing
Frontend:
- src/App.vue is now ~10 lines: <CnAppRoot :app-id :manifest />
- src/router/index.js generates routes from manifest.pages, all pointing
at CnPageRenderer. No hand-rolled views.
- Deleted: navigation/MainMenu.vue, views/Dashboard.vue, views/items/*,
views/settings/UserSettings.vue, views/settings/Settings.vue. Replaced
by the manifest renderer.
- src/store/store.js registers all three schemas with the shared object
store on boot.
Backend:
- SettingsService::loadConfiguration() now uses
ConfigurationService::importFromFilePath() with the path resolved
relative to /var/www/html (\OC::$SERVERROOT). The previous call was
using the wrong importFromApp() signature.
Known follow-ups (not blockers for the tutorial):
- The settings API still returns the register *slug* in `register`;
CnIndexPage's store needs the numeric id. Wire that resolution in a
follow-up so the index pages list seed data without a manual step.
- Translation keys (deskdesk.menu.desks etc.) need l10n entries; for
now they render as raw keys.
Contributor
Quality Report — ConductionNL/deskdesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-10 20:12 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of the DeskDesk tutorial: wire the empty Part 1 shell to real data via OpenRegister + the @conduction/nextcloud-vue manifest renderer.
What's in
Verified
Known follow-ups (not blockers)
Generated with Claude Code