Skip to content

fix(e2e): seed a meeting instead of skipping 21 tests - #941

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/e2e-seed-a-meeting-instead-of-skipping-21-tests
Aug 28, 2026
Merged

fix(e2e): seed a meeting instead of skipping 21 tests#941
rubenvdlinde merged 1 commit into
developmentfrom
fix/e2e-seed-a-meeting-instead-of-skipping-21-tests

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

integration-registry.spec.ts skipped 21 of its tests on a single
development run, and every one of them was counted as a pass.

The condition was:

test.skip(!first, 'no meeting objects on this instance — seed at least one')

That is the normal state of a fresh CI run. tests/e2e/ci-seed.sh
provisions REGISTERS AND SCHEMAS ONLY -- its own header calls the
register import "the ONLY legitimate seed source" -- so no meeting object
exists unless some earlier spec happened to create one. The file's
coverage therefore depended on spec execution ORDER, and quietly reported
nothing-was-tested as success.

A skip cannot distinguish "not applicable here" from "the thing this
needed was never created", and it reports the second as a pass.

Now it seeds. The meeting is always present, so a failure means the
integration registry is genuinely broken rather than absent.

Follows the fixture-marker convention that ci-seed.sh documents, using
the established helper rather than a second scheme:

  • created via seedGovernanceScenario() from workflows/governance-fixture
  • tracked in a per-run ledger (newLedger())
  • deleted in afterAll via cleanupAll(), children before parents
  • meeting is already in that helper's TEARDOWN_ORDER, so nothing leaks

Seeded once and reused across the file, and only when the instance really
has no meeting -- an instance that already has one is untouched.

Verified: npm ci rc=0, npm run lint rc=0 (0 errors), prettier clean, and
playwright test --list compiles all 35 tests in the file.

integration-registry.spec.ts skipped 21 of its tests on a single
development run, and every one of them was counted as a pass.

The condition was:

  test.skip(!first, 'no meeting objects on this instance — seed at least one')

That is the normal state of a fresh CI run. tests/e2e/ci-seed.sh
provisions REGISTERS AND SCHEMAS ONLY -- its own header calls the
register import "the ONLY legitimate seed source" -- so no meeting object
exists unless some earlier spec happened to create one. The file's
coverage therefore depended on spec execution ORDER, and quietly reported
nothing-was-tested as success.

A skip cannot distinguish "not applicable here" from "the thing this
needed was never created", and it reports the second as a pass.

Now it seeds. The meeting is always present, so a failure means the
integration registry is genuinely broken rather than absent.

Follows the fixture-marker convention that ci-seed.sh documents, using
the established helper rather than a second scheme:

  - created via seedGovernanceScenario() from workflows/governance-fixture
  - tracked in a per-run ledger (newLedger())
  - deleted in afterAll via cleanupAll(), children before parents
  - `meeting` is already in that helper's TEARDOWN_ORDER, so nothing leaks

Seeded once and reused across the file, and only when the instance really
has no meeting -- an instance that already has one is untouched.

Verified: npm ci rc=0, npm run lint rc=0 (0 errors), prettier clean, and
`playwright test --list` compiles all 35 tests in the file.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidiq @ 292307f

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-nav-ceiling
test-l10n
format
check-l10n-js
check-schema-l10n
composer ✅ 104/104
npm ✅ 557/557
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-27 22:28 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit ad72a18 into development Aug 28, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant