fix(e2e): seed a meeting instead of skipping 21 tests - #941
Merged
rubenvdlinde merged 1 commit intoAug 28, 2026
Merged
Conversation
integration-registry.spec.ts skipped 21 of its tests on a single development run, and every one of them was counted as a pass. The condition was: test.skip(!first, 'no meeting objects on this instance — seed at least one') That is the normal state of a fresh CI run. tests/e2e/ci-seed.sh provisions REGISTERS AND SCHEMAS ONLY -- its own header calls the register import "the ONLY legitimate seed source" -- so no meeting object exists unless some earlier spec happened to create one. The file's coverage therefore depended on spec execution ORDER, and quietly reported nothing-was-tested as success. A skip cannot distinguish "not applicable here" from "the thing this needed was never created", and it reports the second as a pass. Now it seeds. The meeting is always present, so a failure means the integration registry is genuinely broken rather than absent. Follows the fixture-marker convention that ci-seed.sh documents, using the established helper rather than a second scheme: - created via seedGovernanceScenario() from workflows/governance-fixture - tracked in a per-run ledger (newLedger()) - deleted in afterAll via cleanupAll(), children before parents - `meeting` is already in that helper's TEARDOWN_ORDER, so nothing leaks Seeded once and reused across the file, and only when the instance really has no meeting -- an instance that already has one is untouched. Verified: npm ci rc=0, npm run lint rc=0 (0 errors), prettier clean, and `playwright test --list` compiles all 35 tests in the file.
Contributor
Quality Report — ConductionNL/decidiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-nav-ceiling | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 557/557 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-27 22:28 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-registry.spec.ts skipped 21 of its tests on a single
development run, and every one of them was counted as a pass.
The condition was:
test.skip(!first, 'no meeting objects on this instance — seed at least one')
That is the normal state of a fresh CI run. tests/e2e/ci-seed.sh
provisions REGISTERS AND SCHEMAS ONLY -- its own header calls the
register import "the ONLY legitimate seed source" -- so no meeting object
exists unless some earlier spec happened to create one. The file's
coverage therefore depended on spec execution ORDER, and quietly reported
nothing-was-tested as success.
A skip cannot distinguish "not applicable here" from "the thing this
needed was never created", and it reports the second as a pass.
Now it seeds. The meeting is always present, so a failure means the
integration registry is genuinely broken rather than absent.
Follows the fixture-marker convention that ci-seed.sh documents, using
the established helper rather than a second scheme:
meetingis already in that helper's TEARDOWN_ORDER, so nothing leaksSeeded once and reused across the file, and only when the instance really
has no meeting -- an instance that already has one is untouched.
Verified: npm ci rc=0, npm run lint rc=0 (0 errors), prettier clean, and
playwright test --listcompiles all 35 tests in the file.