fix(nav): let users reach Personal settings again - #1113
Merged
rubenvdlinde merged 2 commits intoSep 3, 2026
Merged
Conversation
The manifest carried `nav.includePersonalSettings: false`, which turns off the entry CnAppNav auto-prepends at the top of the settings foldout. There was no note saying why, and nothing replaced it. That entry is not decoration. It opens CnAppRoot's NcAppSettingsDialog, whose `#user-settings` slot falls back to the user's NOTIFICATION PREFERENCES and renders the ADR-110 Integrations section below them. Suppressing the entry put both out of reach from inside the app entirely. The flag is legitimate for an app that declares its own entry with `action: "user-settings"`, which opens the same dialog: keepiq does exactly that and injects its own Session / Security / Encryption sections into the slot, so re-enabling the shell copy there would give it two entries onto one dialog. This app declares no such entry, so the flag was simply hiding a surface. Found by pointing gate-107 (ADR-114, the seven-item app chrome) at the fleet: three apps set this flag, and only keepiq had a replacement.
Contributor
Quality Report — ConductionNL/decidiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-nav-ceiling | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 537/537 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 11:32 UTC
Download the full PDF report from the workflow artifacts.
testSeamAndServiceCannotDiverge fails intermittently on `development`, and
every branch cut from it inherits the red. Observed 2026-09-03 on CI:
'decidedAt' => '2026-09-03T11:30:08+00:00' expected
'decidedAt' => '2026-09-03T11:30:09+00:00' actual
`decidedAt` is a wall-clock reading that each path stamps for itself. The two
calls run microseconds apart, so whenever they straddle a second boundary the
arrays differ by exactly one second and the test fails for a reason that has
nothing to do with the divergence it exists to catch.
NORMALISED rather than unset. Whether a decided stage records a decision time
at all IS part of what must not diverge, so both paths still have to agree that
there is one; they no longer have to agree on the second. Dropping the key
would have widened the test into passing over a path that stopped stamping it.
The sibling provenance fields (`id`, `decision`, `route`, `taskUuid`) were
already stripped for the same class of reason.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
September 3, 2026 11:51
Contributor
Quality Report — ConductionNL/decidiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-nav-ceiling | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 537/537 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 12:00 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Both apps carried
nav.includePersonalSettings: falsewith no note and nothing in its place. That flag turns off the entryCnAppNavauto-prepends at the top of the settings foldout.That entry is not decoration. It opens
CnAppRoot'sNcAppSettingsDialog, whose#user-settingsslot falls back to the user's notification preferences and renders the ADR-110 Integrations section below them. Suppressing it put both out of reach from inside the app entirely.When the flag is correct
For an app that declares its own entry with
action: "user-settings", which opens the same dialog. keepiq does exactly that and injects its own Session / Security / Encryption sections into the slot, so re-enabling the shell copy there would give it two entries onto one dialog. keepiq is right and is untouched.Neither of these two declares such an entry, so the flag was only hiding a surface.
How it was found
Pointing gate-107 (ADR-114, the seven-item app chrome) at the fleet. Three apps set the flag; only keepiq had a replacement. The rule is added to the gate in
ConductionNL/.githubso this cannot recur, with keepiq's shape as the fixture's anti-widening control.🤖 Generated with Claude Code