fix(decisions): feed the detail pages' type picker from the registry

[rubenvdlinde]

Closes the known gap #1109 filed: its index-page fix could not reach the detail pages, because CnDetailPage had no seam to reach them through.

The defect

#1099 moved the decisionType vocabulary out of the stored schema's enum and into the decision_types app config, which is now the only authority. #1109 spliced it back into the Decisions and Motions index dialogs through CnIndexPage's form-dialog slot, and said so plainly: the detail pages' built-in Edit dialog still read the emptied enum, so the picker offered nothing while the field stayed required. A form that cannot be completed.

CnDetailPage grew the same slot, with deliberately the same name and the same scope, in nextcloud-vue#944, published as 2.34.0. This takes that version and wires the detail surfaces.

Four surfaces, not one

The gap named the decision detail page. The sweep found four, and the fourth is the one worth naming:

Page	Route	Why it renders the form
DecisionDetail	/decisions/:id	schema decision
MotionDetail	/motions/:id	same polymorphic schema, decisionType=motion
AmendmentDetail	/amendments/:id	same schema, decisionType=amendment
DecisionIntegrations	/decisions/:id/integrations	also type: "detail" with a config.schema

CnPageRenderer sets showEditAction on a schema-bound detail page unconditionally, so the integrations surface offers the same Edit dialog over the same schema and had the same empty picker. Nothing about the page suggests it, which is exactly why it was missed.

MotionIntegrations is deliberately NOT wired: it mounts CnDetailPage by hand and passes no schema, so it renders no form dialog at all.

No second copy of the vocabulary logic

All four reuse #1109's DecisionFormDialog and its withDecisionTypeVocabulary() helper, through each page's slots map. Six wirings, one splice, so they cannot drift. The schema handed to the form is a copy; the store's schema is never mutated.

The locked-modal trap

One behavioural change in DecisionFormDialog, and it is the reason the slot's contract is shaped the way it is. A replacement holds the only ref to its own CnFormDialog, which raises loading on submit; only setResult() lowers it, and no-close is bound to loading. CnDetailPage leaves the form open on a failed edit, so a replacement that drops the resolved result strands the user in a modal that can neither retry nor close, with nothing in the console.

settleFormDialogResult() (new, src/dialogs/formDialogResult.js) hands confirm's resolved { success, data } / { error } back to the dialog, and treats "resolved to nothing" as a normal outcome rather than a fault. That is still what CnIndexPage's confirm does, so the same component keeps serving the index pages unchanged.

Tests

tests/vitest/decisionDetailFormDialog.spec.js, 15 tests in this repo's idiom (logic in importable .js, manifest asserted against src/manifest.json itself, since vitest here runs without @vitejs/plugin-vue):

• Coverage as an equality, not a subset. The set of detail pages bound to the decision schema must be exactly the four wired ones, so a fifth page cannot ship with the defect while the test stays green. Mutation-checked: removing MotionDetail's wiring fails the run.
• Negative control from the shipped schema. lib/Settings/decidesk_register.json's Decision carries no decisionType enum and lists it as required, which is precisely zero options in the built-in dialog. Passing that same schema through the helper yields the registry vocabulary, and the seed while the fetch is still in flight.
• The locked-modal trap. settleFormDialogResult closes on success, unlocks on failure, stays out of the way for a confirm that resolves to nothing, and survives the dialog having unmounted mid-save.

Verified locally

Check	Result
vitest	28 files, 407 tests green
eslint	0 errors (248 pre-existing warnings)
prettier format	clean
stylelint	0 errors
check:manifest (Ajv)	PASS, 0 errors
check:schema-l10n, test:l10n, check:nav-ceiling	at baseline
hydra gates v1.11.0, --scope-to-diff vs origin/development	48 of 48 applicable gates green
npm bump	package.json and package-lock.json both on 2.34.0, installed build carries the slot

No PHP changed, so the PHP suite is untouched by this diff.

🤖 Generated with Claude Code

[github-actions]

Quality Report — ConductionNL/decidiq @ 1be173d

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-nav-ceiling		✅
test-l10n		✅
format		✅
check-l10n-js		✅
check-schema-l10n		✅
composer			✅	✅ 104/104
npm			✅	✅ 537/537
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					✅
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-09-03 11:31 UTC

Download the full PDF report from the workflow artifacts.