fix(approval-routes): advance stages through OR's patch path, and feed the type picker from the registry

[rubenvdlinde]

Fixes two defects from the live rig proof (DC#1101 seam, DC#1099 registry).

Defect: partial stage saves 400, routes can never advance (HIGH)

ApprovalRouteService::completeAndAdvance and its siblings saved PARTIAL DecisionStage payloads (status/outcome/decidedAt) with a uuid. OpenRegister validates a uuid-bearing save as a FULL REPLACE, so every stage transition 400d on the required sequence, stageType, decisionMakerType and label it omitted — no approval route raised over the dossiq seam could advance or conclude, and POST /api/approval-routes/actions returned 400 (reproduced twice on the rig).

Fix chosen: OR's sanctioned patch path, not hand-rolled read-modify-write. The vendored contract (conduction/hydra-gates v1.11.0) and OR development both carry patchObject(), the RFC 7386-shaped merge counterpart to the replacing save. RegisterObjectStore::patch() wraps it; every stage transition now goes through it, so schema validation, the audit trail and event dispatch still apply and an explicit null still clears outcome/decidedAt on a rewind.

Sweep (one fix is not the class). The same class was found and fixed at:

• ApprovalRouteService: 5 sites (complete, advance, terminal return, rewind reset x2)
• ApprovalStageTaskProjector: 2 sites (taskUuid linkage set/clear)
• AgendaService: 3 sites — advanceBobPhase, processHamerstukken and reorderItems all 400d the same way (agenda-item requires title, itemType, orderNumber)

Left deliberately on the replacing save: the declared-state upserts in GovernanceBodyCommandService (upsert, upsertMembership) and ApprovalRouteCommandService::holdRoute — their payloads carry every required property and the seam's documented semantics are "the producer states it", where a merge would keep stale fields a producer meant to clear. ApiController::write documents its PUT semantics on the public surface and is likewise intentional.

Tests that can now fail. The route-engine fakes MERGED uuid-bearing saves — the exact behaviour live OR does not have — so the suite was green while every advance 400d in production. The fakes in ApprovalRouteServiceTest, ParaferingRouteRuntimeTest and ApprovalRouteCommandServiceTest now REPLACE and validate required properties per schema exactly like live OR (and merge only through patchObject). Negative control: the old code fails 9 tests against the corrected fakes with the rig's own "required properties … are missing" refusal; the fixed code passes all of them, pinning route advance and conclusion end-to-end.

Defect: type picker ignores the registry (MEDIUM)

CnDecisionsTab and CnDecisionsWidget hardcoded 5 decision types in the create-proposal picker; the DecisionTypeRegistry (13 seeded, admin-extensible) was consulted only for validation, so an admin-added type never appeared.

• New GET /api/v1/decision-types (DecisionTypesController) serves the registry's vocabulary — the pickers render inside foreign apps' pages, where decidiq initial state never loads, so an endpoint is the only channel that reaches them. Same guarded pattern as the integration hub: #[NoAdminRequired] + session check, 401 for anonymous callers.
• Both pickers build their schema from a shared proposalFormSchema() in decisionLink.js; an unreachable registry degrades to the shipped 13-type seed instead of blocking creation.
• The 13 shipped types carry translated labels (enumLabels) — 9 new catalogue keys translated into every locale the app ships, Dutch and English included; an admin-added type renders as its own slug.
• Coverage: vitest pins that an admin-added type appears in the picker schema and that the fallback engages; a PHPUnit controller test pins the endpoint's answer and the 401.

Verification

• composer lint / phpcs / phpmd / psalm / phpstan: green (run individually)
• PHPUnit: 1356 tests, 0 failures; vitest: 388 tests, 0 failures
• test:l10n, check:l10n-js, check:schema-l10n (ratchet lowered by 1), check:manifest, eslint (0 errors, warning count unchanged from development)
• hydra gates v1.11.0 --scope-to-diff vs origin/development: 56/56 applicable gates pass

[github-actions]

Quality Report — ConductionNL/decidiq @ 4effc0e

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-nav-ceiling		✅
test-l10n		✅
format		❌
check-l10n-js		✅
check-schema-l10n		✅
composer			✅	✅ 104/104
npm			✅	✅ 537/537
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					❌
Newman					❌
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					❌

---

Quality workflow — 2026-09-02 18:41 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/decidiq @ 38ec835

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-nav-ceiling		✅
test-l10n		✅
format		✅
check-l10n-js		✅
check-schema-l10n		✅
composer			✅	✅ 104/104
npm			✅	✅ 537/537
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					✅
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-09-02 19:14 UTC

Download the full PDF report from the workflow artifacts.