Skip to content

fix(e2e): make the suite load again after the lint sweep #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Sep 1, 2026
Merged

fix(e2e): make the suite load again after the lint sweep #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/e2e/workflows/crud-persistence.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,11 @@ test.beforeEach(({ page }) => {
// That error aborts the WHOLE SUITE before a single test runs — 0 collected, no
// tally, and the failure names this file rather than anything under test. `{}`
// is the documented way to say "no fixtures, but give me testInfo".
test.afterEach(async (_fixtures, testInfo) => {
// Playwright requires the first argument to BE an object destructuring
// pattern; a plain identifier makes the file fail to load, so an empty one
// is how a callback says it needs no fixtures.
// eslint-disable-next-line no-empty-pattern
test.afterEach(async ({}, testInfo) => {
if (testInfo.status === testInfo.expectedStatus) return
const dump = traffic
.map((c) =>
Expand Down
8 changes: 4 additions & 4 deletions tests/e2e/workflows/rbac-authorization-workflow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const ADMIN_GATED_ENDPOINTS = [

test.describe('consume-or-rbac-authorization — who-may-act preserved via OR RBAC', () => {
test('a signatory may initiate signing; a non-signatory is denied (403)', async ({
_page,
page: _page,
}) => {
// Deferred live run: requires decidiq deployed with a Minutes record on a
// body whose signatory scope (decidesk:body:{id}:signatory) is populated by
Expand All @@ -82,7 +82,7 @@ test.describe('consume-or-rbac-authorization — who-may-act preserved via OR RB
})

test('only the chair may run a chair-only lifecycle transition', async ({
_page,
page: _page,
}) => {
// Deferred live run: a chair-only transition (e.g. legislative opened→adjourned)
// succeeds for a member of decidesk:body:{id}:chair and is refused for a
Expand All @@ -97,7 +97,7 @@ test.describe('consume-or-rbac-authorization — who-may-act preserved via OR RB
})

test('a disallowed domain transition is refused independent of actor scope', async ({
_page,
page: _page,
}) => {
// Deferred live run: a domain whose workflow sets allowPause:false refuses
// opened→paused for the chair too (workflow policy, not actor auth). Asserted
Expand All @@ -110,7 +110,7 @@ test.describe('consume-or-rbac-authorization — who-may-act preserved via OR RB
})

test('a non-admin is denied on every previously admin-gated surface; an admin is allowed', async ({
_page,
page: _page,
}) => {
// Deferred live run: as a non-admin, each ADMIN_GATED_ENDPOINTS call returns
// 401/403 from the shared RequiresOrAdmin trait; as an admin each is permitted.
Expand Down
Loading