Repository navigation
CI: save the Windows x64 build as a downloadable artifact - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — merge only on Con's word. CI-only change to
.github/workflows/ci.yml(windows job). No product code, no tag, no release;release.yml,contracts/and receipt.v0 untouched.After the existing build/tests, the windows job stages the same layout as the release zip (qorcap.exe + sha256, .cmd launchers, scripts, docs, sidecar/, contracts/, ffmpeg via get-ffmpeg.ps1, the pinned QorTime checkout), checks it with
sidecar/qorcap_release.py --install-root, writesCI-BUILD.txt(commit, run URL, exe sha256), and uploads it withactions/upload-artifact@v4asqorcap-<shortsha>-windows-x64(PR head sha on PRs), retention 14 days,if-no-files-found: error.Intended use: a practice-only install of a main build behind the LIVE shortcut. REAL MATCH stays on v0.3.38.
Local check:
tools/test_assert_pytest_skips.py(reads ci.yml) 31 passed; YAML parses. The real proof is this PR's windows job uploading the artifact.