Fix high/critical audit findings and add CI dependency-audit gate - #13
Merged
Conversation
Upgrades: - http-proxy-middleware ^1.0.3 -> ^3.0.6 (GHSA-c7qv-q95q-8v27, high). Nothing imports it directly and the existing resolutions entry already forced nested copies to 3.0.7; this aligns the direct dependency. - websocket-driver -> ^0.7.5 via resolutions (GHSA-xv26-6w52-cph6, critical, via webpack-dev-server > sockjs). Two advisories cannot be fixed by upgrade and are allowlisted with justifications in scripts/audit-allowlist.json: - GHSA-v7cw-rxgx-j29p (compound-components): false positive; our dep is a pinned git URL, the advisory targets a name-squatted npm package. - GHSA-2p57-rm9w-gvfp (ip): no patched release exists; dev-only via webpack-dev-server v3. Removable by upgrading to webpack-dev-server 4+. The new audit workflow runs scripts/audit-check.js, which parses `yarn audit --json` and fails on any non-allowlisted high/critical advisory (yarn 1's --level flag does not gate its exit code). Production build verified passing after the upgrades. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
coburncoburn
approved these changes
Jul 22, 2026
3 tasks
torreyatcitty
added a commit
that referenced
this pull request
Jul 22, 2026
New advisories published after the audit gate merged in #13. All four packages were already force-deduped to a single version by the existing resolutions block, so these are same-major bumps of what the build already runs: - tar ^7.5.16 -> ^7.5.19 (GHSA-23hp-3jrh-7fpw critical DoS, GHSA-8x88-c5mf-7j5w high infinite loop) - js-yaml ^4.1.1 -> ^4.3.0 (GHSA-52cp-r559-cp3m high quadratic CPU) - brace-expansion ^2.0.2 -> ^2.1.2 (GHSA-3jxr-9vmj-r5cp high exponential expansion) - fast-uri ^3.1.4 added (GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6 high host confusion) Audit gate exits 0 again; production build verified passing. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security team requirement: dependency audits at the high level must pass in CI. This PR fixes the fixable high/critical findings (audit was 5 high + 4 critical) and adds the gate.
Dependency fixes
^1.0.3→^3.0.6(high, GHSA-c7qv-q95q-8v27). Nothing in scripts/config imports it directly, and the existingresolutionsentry already forced every nested copy to 3.0.7 — yarn 1 resolutions just don't apply to direct deps, so the direct dependency was stuck at vulnerable 1.3.1. This aligns it with what already runs.^0.7.5via resolutions (critical, GHSA-xv26-6w52-cph6, via webpack-dev-server → sockjs). Patch-level bump, same pattern as the existing resolutions. (Supersedes the open dependabot branch for the same advisory.)Full production
yarn buildpasses after the upgrades.Allowlisted advisories (cannot be fixed by upgrade)
Documented with justifications in
scripts/audit-allowlist.json; printed in every CI run:compound-components"malware" (critical) — false positive. Our dependency is a pinned-commit git URL to Compound-Foundation/compound-components; the advisory targets a name-squatted package on the public npm registry, and yarn audit matches by name only.ipSSRF (high) — no patched release ofipexists (the advisory covers every version). Dev-only via webpack-dev-server v3's local dev server; not in the production build. Goes away entirely if/when webpack-dev-server is upgraded to v4+ (which droppedip), noted in the allowlist entry.CI gate
.github/workflows/audit.yml— checkout + node, thennode scripts/audit-check.js. No yarn install needed (audit runs off the lockfile), so the job takes seconds.scripts/audit-check.js— parsesyarn audit --jsonand fails on any non-allowlisted high/critical advisory. A wrapper is required because yarn 1's--level highonly filters the printed report; its exit code still reflects low/moderate findings (this repo has ~180, which the gate intentionally ignores).Test plan
yarn build(production build) passes with the upgraded dependenciesnode scripts/audit-check.jsexits 0, printing the two allowlisted advisories with justificationsDependency Auditworkflow green on this PR🤖 Generated with Claude Code