Fix building Ubuntu 26.04 HTML guides - #15083
Merged
Merged
Conversation
The Ubuntu 26.04 product doesn't have any profile except the virtual default profile, therefore, no HTML guide is built, and the builder fails when building the index.html index. It manifests only if the `lxml` library isn't present and the build system falls back to the legacy script `build_all_guides.py`. This problem currently causes that the scap-security-guide package doesn't build on Fedora, eg.: https://src.fedoraproject.org/rpms/scap-security-guide/pull-request/81 Addressing: ``` $ python3 build-scripts/build_all_guides.py --input build/ssg-ubuntu2604-ds.xml --output build/guides build Traceback (most recent call last): File "/home/jcerny/work/git/scap-security-guide/build-scripts/build_all_guides.py", line 109, in <module> main() ~~~~^^ File "/home/jcerny/work/git/scap-security-guide/build-scripts/build_all_guides.py", line 100, in main index_source = ssg.build_guides.build_index(benchmarks, input_basename, index_links, index_options, index_initial_src) File "/home/jcerny/work/git/scap-security-guide/ssg/build_guides.py", line 224, in build_index index_select_options += "\n".join(list(index_options.values())[0]) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^ IndexError: list index out of range ```
jan-cerny
requested review from
Mab879,
ggbecker,
marcusburghardt and
vojtapolasek
as code owners
September 3, 2026 09:59
Mab879
approved these changes
Sep 3, 2026
Member
|
The testing farm failures seem to be an infra issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ubuntu 26.04 product doesn't have any profile except the virtual default profile, therefore, no HTML guide is built, and the builder fails when building the index.html index. It manifests only if the
lxmllibrary isn't present and the build system falls back to the legacy scriptbuild_all_guides.py. This problem currently causes that the scap-security-guide package doesn't build on Fedora, eg.: https://src.fedoraproject.org/rpms/scap-security-guide/pull-request/81Addressing: