Adjust sysctl bash template to use build time variables - #15017
Merged
Conversation
Mab879
added
the
backported-into-stabilization
|
@Mab879: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ggbecker
reviewed
Aug 21, 2026
| # | ||
| {{% if sysctl_remediate_drop_in_file == "true" %}} | ||
| sed -i "/^$SYSCONFIG_VAR/d" /etc/sysctl.conf | ||
| sed -i "/^{{{ SYSCONFIG_VAR }}}/d" /etc/sysctl.conf |
Member
There was a problem hiding this comment.
I struggle to find the definition of SYSCONFIG_VAR though...
Should we use something like
Suggested change
| sed -i "/^{{{ SYSCONFIG_VAR }}}/d" /etc/sysctl.conf | |
| sed -i "/^{{{ SYSCTLVAR }}}/d" /etc/sysctl.conf |
here?
Mab879
force-pushed
the
fix_up_2026_08_19
branch
from
August 21, 2026 14:10
58f096b to
8e92507
Compare
Mab879
force-pushed
the
fix_up_2026_08_19
branch
from
August 21, 2026 14:23
8e92507 to
cb22069
Compare
ggbecker
approved these changes
Aug 21, 2026
Member
|
no need to wait for the ansible lint to finish (which seems stuck), it's only a bash related change what the PR is proposing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adjust sysctl bash template to use build time variables
Rationale:
Should fix a few issues with bash substitution.