CMP-3730: Updated banner_etc_issue to use variable

[vickeybrown]

Description:

banner_etc_issue currently uses a hardcoded remediation value, while the check allows for the configuration of different values via variable. This update changes it to follow that flow to allow for successful remediations.

This won't work without also having the changes in ComplianceAsCode/compliance-operator#1198

[openshift-ci]

Hi @vickeybrown. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yuumasato]

/ok-to-test

[vickeybrown]

/retest-required

[rhmdnd]

/ok-to-test

[vickeybrown]

/retest

[Vincent056]

/ok-to-test

[vickeybrown]

/test e2e-aws-openshift-node-compliance

[yuumasato]

Looks good, just a minor clean up on legacy remediation metadata.

[yuumasato]

@vickeybrown Please, remove the whole metadata block, it is not necessary and the role can be misleading, since the remediation applies on both master and worker.
CO will infer the role based on the pools it is scanning and remediating, and the MC name is inferred from the rule name

See these for example:

• content/shared/macros/10-kubernetes.jinja

  Line 638 in d7ad56f

  kind: MachineConfig

• content/linux_os/guide/auditing/policy_rules/audit_modify_failed/kubernetes/shared.yml

  Line 5 in d7ad56f

  spec:

[openshift-ci]

@vickeybrown: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-openshift-node-compliance	d9c2a14	link	true	/test e2e-aws-openshift-node-compliance
ci/prow/e2e-aws-openshift-platform-compliance	3769e9d	link	true	/test e2e-aws-openshift-platform-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yuumasato]

/lgtm

Taimur's changes have been addressed.