Change applicability of some rules in containers and in Image Mode - #13899
Conversation
The most common changes: - mark rules related to systemd services as notapplicable in containers because containers typically don't run systemd and can't run services, they usually run a single process or single application - mark rules that depend on CPU or other hardware features as notapplicable in containers because containers don't have direct hardware access - mark rules related to log in or password management as notapplicable in containers because you typically don't login to containers
jan-cerny
added
RHEL10
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/packit build |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/test e2e-aws-openshift-platform-compliance |
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
comps
left a comment
comps
left a comment
There was a problem hiding this comment.
LGTM, and it also fixes the recent failures in our automated container testing.
3 participants
Description:
This PR changes
platformkey in multiple rules in order to change rule applicability in Image Mode and/or Container environment or both.The most common changes:
Rationale:
This change is based on our applicability analysis which we did for all rules used in any RHEL 10 profiles.
The goal is more consistent applicability results in different environments.
Review Hints:
I have run these contest tests on RHEL 10 using this PR as a custom pipeline and all of them passed: