Skip to content

kernel_module_vfat_disabled: limit to non-uefi - #13883

Merged
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
xnox:vfat
Sep 17, 2025
Merged

kernel_module_vfat_disabled: limit to non-uefi#13883
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
xnox:vfat

Conversation

@xnox

@xnox xnox commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Currently kernel_module_vfat_disabled is low or failed on systems with
a kernel. However, on UEFI platforms VFAT is required to access ESP
and is typically built-in. Blocking modprobe of it is a no-op, and
VFAT usage is required on such systems.

Thus limit the platform of this rule to non-uefi systems, as only on
those platforms one can realistically run without VFAT support.

Another option is to remove this rule entirely. Many distributions
make VFAT built-in even on those architectures / platforms that do not
use VFAT for booting.

Currently kernel_module_vfat_disabled is low or failed on systems with
a kernel. However, on UEFI platforms VFAT is required to access ESP
and is typically built-in. Blocking modprobe of it is a no-op, and
VFAT usage is required on such systems.

Thus limit the platform of this rule to non-uefi systems, as only on
those platforms one can realistically run without VFAT support.

Another option is to remove this rule entirely. Many distributions
make VFAT built-in even on those architectures / platforms that do not
use VFAT for booting.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 11, 2025
@openshift-ci

openshift-ci Bot commented Sep 11, 2025

Copy link
Copy Markdown

Hi @xnox. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jan-cerny jan-cerny self-assigned this Sep 16, 2025
@jan-cerny jan-cerny added this to the 0.1.79 milestone Sep 16, 2025
@jan-cerny jan-cerny added the CPE-AL CPE Applicability Language label Sep 16, 2025
@xnox

xnox commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

@jan-cerny are you able to trigger the Pending approval, waiting for an /ok-to-test thing please?

@jan-cerny
jan-cerny merged commit 360fac7 into ComplianceAsCode:master Sep 17, 2025
121 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CPE-AL CPE Applicability Language needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants