Skip to content

Add cis designated nist time servers - #13819

Merged
Mab879 merged 3 commits into
ComplianceAsCode:masterfrom
alanmcanonical:time_srv
Sep 3, 2025
Merged

Add cis designated nist time servers#13819
Mab879 merged 3 commits into
ComplianceAsCode:masterfrom
alanmcanonical:time_srv

Conversation

@alanmcanonical

Copy link
Copy Markdown
Contributor

Description:

  • cis ubuntu 24.04/22.04 rule 2.3.2.1 lists several authoritative time server examples

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 26, 2025
@openshift-ci

openshift-ci Bot commented Aug 26, 2025

Copy link
Copy Markdown

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mab879 Mab879 self-assigned this Aug 26, 2025
@Mab879 Mab879 added this to the 0.1.79 milestone Aug 26, 2025
@Mab879

Mab879 commented Aug 26, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Aug 26, 2025
@Mab879

Mab879 commented Aug 26, 2025

Copy link
Copy Markdown
Member

@alanmcanonical Please resolve the merge conflicts.

Signed-off-by: Alan Moore <alan.moore@canonical.com>
Signed-off-by: Alan Moore <alan.moore@canonical.com>
Comment thread linux_os/guide/services/ntp/var_multiple_time_pools.var
@Mab879

Mab879 commented Sep 2, 2025

Copy link
Copy Markdown
Member

Can you please add test scenario for this nist variable in chronyd_configure_pool_and_server?

Signed-off-by: Alan Moore <alan.moore@canonical.com>
@alanmcanonical

alanmcanonical commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

Can you please add test scenario for this nist variable in chronyd_configure_pool_and_server?

Test added but the tests incorrect_line* are known to fail because the inconsistency between fix and check.

The oval only allows single space between directive and url while the remediation check if lines contain urls are starting with "directives " (server /pool ). So the remediation will skip the (should fail) test cases.

@Mab879
Mab879 merged commit 31c4204 into ComplianceAsCode:master Sep 3, 2025
129 of 131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants