Repository navigation
Port #61/#62/#63: one-image icon prompt, honest seed provenance, size_class values - #129
Merged
Merged
Conversation
Rewrite the icon generation recipe for single-image invocations: pipeline rules 4 and 7, the option A template line, the Command notes (CLI help does not prove generation), the image-path item 5, the per-slot retry limits, sandbox item (c) and the provenance "Images requested" line. Privacy, retrieval and $CODEX_HOME semantics are unchanged. The Repository icon ground bullet is not changed. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
- size_class_help() lists WIDE, TALL, SQUARE and DIAGONAL with one-line meanings
- invalid SIZE_CLASS is recorded (needs-writer:SIZE_CLASS:invalid) and the error names the allowed values
- icon_prompt takes an explicit seed (--seed); without it the prompt and provenance say "not supported"
- prompt asks for one image; legacy four-candidate and "Use seed" phrases are rewritten
- output path is {repo}-1024.png
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…_class values Replace the merged #64 four-candidate pins with single-image invariants; add tests for size_class errors, --seed, and the legacy seed rewrite; document in SKILL.md, references/content.md and CHANGELOG. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
Item 5 and sandbox (c) now select the first readable path reported by the same invocation, and count only runs with no readable path as empty. Retry limits state the first-readable-path rule. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…ance range - icon_ground_tolerance: --ground-tolerance must be a finite dE from 0 to 12 (CONTENT_DE); NaN, inf, negatives, bools and strings are usage errors. normalize_icon delegates to it; _cmd_icon validates before reading --in. - icon_qa(exact_contrast=False): when set, the dominant ink is measured at the most common actual RGB in its 16-level bucket instead of the bucket midpoint. _cmd_icon sets it only when --min-contrast or icon_min_contrast is configured; the unconfigured default keeps the legacy midpoint measurement. - Drop the now-unused math import. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… range, first-readable-path recipe tests and docs Tests reproduced on 8f27ef1: icon_qa(min_contrast=4.5) on solid #707070 over #F8FAFC measured the bucket midpoint #787878 (4.22:1); --ground transparent --ground-tolerance 1000 gave icon-empty; recipe item 5 and sandbox (c) dropped the readable fallback path. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
One invocation fills at most one candidate slot but may report several paths; the candidate is the first readable reported path. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the recipe Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…de compatibility Rename the pre-#61 override compatibility test to use the minimal synthetic legacy fixture (ART_DIRECTION.synthetic-legacy.md) instead of the full production snapshot, and guard that the fixture stays synthetic and keeps exactly one 'Produce four candidates.' line. Assertions are unchanged. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Replaces the production-derived previous-bundled snapshot reference with a minimal synthetic legacy template that keeps the old four-candidate and seed wording. Original remains in git history (baa3c02, 71ffd4a). Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Remove the production-derived previous-bundled snapshot (kept in history at baa3c02/71ffd4a). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the repo-icon prompt honest for single-image generators, lists the valid
size_classvalues in the error, and ports the epic review fixes that were still missing from main.size_classvalues in the error and docs #62/E3.3.2 Reword the prompt and provenance block #63 contract). The Codex recipe (references/art-direction.md) now runs rule 7 as four single-image invocations with a per-slot empty/unreadable retry cap, exact returned paths and the first-readable-path fallback; the merged Document the Codex image-generation workflow and its pitfalls #64 four-candidate test pins are replaced by single-image invariants.size_classsuch asmediumnames the allowed values (WIDE, TALL, SQUARE, DIAGONAL) with their meanings.references/art-direction.md,references/content.md,SKILL.md,CHANGELOG.md.Why
Resolves #61
Resolves #62
Resolves #63
Preserves the delivered #52/#57/#64 behavior.
Prior work
Searched open and closed PRs and issues for #61, #62, #63 and branch
issue/61-scoped: no other PR covers this. Related merged work: #128 (#64 Codex recipe), #127 (#57), #126 (#52), #124 (#47). The original combined E3 candidate (baa3c02 / 71ffd4a) is kept as provenance only; this PR carries just the remaining scoped parts.Tests and evidence (head
110387f352c855002d7d5834c5828605ef730a44, base main3cb83c22ea9622e3b437d9a33d71e809d5cd99eb)vm-110387f3...-result.json); whole-tree ruff passes.i61-r4on this head): 1283 passed, 18 skipped.tests/fixtures/content/ART_DIRECTION.synthetic-legacy.md) that keeps only the old template syntax and the old four-candidate and seed wording. Both A/B compatibility assertions are kept. Original provenance stays in Git history.references/art-direction.mdtolerance sentence says the value must be finite and at least 0, while the CLI enforces 0 to 12; tracked as a wording nit, no behaviour impact.🤖 Generated with Claude Code