Serve footer logos from the published brand assets and keep legacy URLs migratable

.github/workflows/footer-assets.yml

@@ -0,0 +1,53 @@
+# Footer assets
+# Fails on any result other than pass, e.g. when a footer logo URL returns 404 (issue 47, subissue 50).
+# Flag spelling confirmed with `python scripts/showcase.py footer --check --help`: `--check README.md --online`
+# HEADs both decision 18 raw logo URLs (on main) and exits non-zero unless both return 200.
+# Triggers: push to main (a regression is caught as it lands), weekly schedule and manual dispatch run the online HEAD.
+# A pull request cannot be judged by HEADing main, so it runs an offline step instead: the configured footer logo
+# paths must exist in the PR checkout under assets/brand/.
+
+name: Footer assets
+
+on:
+  schedule:
+    - cron: '17 6 * * 1'
+  workflow_dispatch:
+  push:
+    branches: [main]
+    paths:
+      - references/brand.yaml
+      - README.md
+      - assets/brand/**
+      - scripts/ctshowcase/footer.py
+      - .github/workflows/footer-assets.yml
+  pull_request:
+    paths:
+      - references/brand.yaml
+      - README.md
+      - assets/brand/**
+      - scripts/ctshowcase/footer.py
+      - .github/workflows/footer-assets.yml
+
+permissions:
+  contents: read
+
+jobs:
+  footer-online:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+      - name: Install Python dependencies
+        run: python -m pip install -r requirements.txt
+      - name: Footer logo files exist in this checkout
+        if: github.event_name == 'pull_request'
+        run: |
+          python -c "import pathlib, sys, yaml; from urllib.parse import urlparse; f = yaml.safe_load(open('references/brand.yaml', encoding='utf-8'))['footer']; urls = [f['logo_light_url'], f['logo_dark_url']]; bad = [u for u in urls if not pathlib.Path(*urlparse(u).path.split('/main/', 1)[1].split('/')).is_file()]; print('missing in checkout:', bad) if bad else print('footer logo files present:', urls); sys.exit(1 if bad else 0)"
+      - name: Real HEAD against footer logo URLs
+        if: github.event_name != 'pull_request'
+        run: python scripts/showcase.py footer --check README.md --online

CHANGELOG.md

@@ -12,6 +12,9 @@ All notable changes to `github-showcase-skill` are recorded here. Versions follo
 
 ### Fixed
 
+- `readme --bootstrap --write` no longer regenerates a marked footer that holds authored content. When the edited-template upgrade is refused by the never-drop-a-line check and the marked footer carries a partner or foreign image, the command now exits with a check failure (`readme-shrink`) and leaves `README.md` unchanged instead of falling back to a header refresh that rewrote the footer; a plain old footer copy still takes the fallback. The same refusal now applies in every bootstrap state (pristine and unmarked as well as edited), checked before any write, so a pristine or unmarked template can no longer silently replace a partner or foreign footer image.
+- Fork (G) and backup (H) READMEs migrate an unmarked trailing footer whose logo is a configured own-site historical source (`footer.legacy_logo_urls` or `docs/images/logo.svg`) to the single current footer; partner, foreign and look-alike images stay authored and are reported as no allowance.
+- Own-site historical footer logo recognition is URL-derived: the company-website logo lives in `footer.legacy_logo_urls` in `references/brand.yaml` (lock refreshed through `config --write-lock`) and matches only exactly (scheme, host case-insensitively, port, path; no userinfo), so no brand host or path remains in Python. The generic local `docs/images/logo.svg` migration is a file convention, not brand data, and stays distinct.
 - Windows contributor tests now use explicit UTF-8, native path basenames, a platform-independent read-only metadata stub, and Git Bash with stdin-safe Action scripts. All 15 issue #9 failures are individually documented; the full suite now runs in Windows, Linux and macOS CI.
 - Lint accepts file operands after options on older Python 3.12 versions while continuing to reject unrecognized options.
 - The Action's optional render arguments support macOS Bash 3.2, including an empty argument array with `set -u`.
@@ -21,6 +24,9 @@ All notable changes to `github-showcase-skill` are recorded here. Versions follo
 - `content icon` uses the bundled `references/art-direction.md` in every working directory. The option A glyph template uses dedicated, contrasting `icon_ink` and `icon_spark` brand tokens and the documented family seed (or the tool's default when absent) without requiring private estate files; explicit art-direction overrides remain supported and missing paths are named in the error.
 - CLI stdout and stderr are configured as UTF-8 before argument parsing, preserving their existing error handlers, so redirected Windows output preserves Unicode in label plans, raw footer markup, help and diagnostics without `UnicodeEncodeError`, and undecodable filenames still use the stream's original escape policy.
 - The Action summary and quality validator decode CLI results explicitly as UTF-8, preserving non-ASCII descriptions on Windows rather than corrupting them or failing with `UnicodeDecodeError`.
+- Footer logo URLs now use the existing published masters in this skill instead of missing `.github/brand` files. README refresh safely migrates the former URLs without dropping authored partner credits; the decision 18 artwork, theme selection and credit remain unchanged. Fork and backup READMEs (variants G and H) migrate the former footer too, and a custom footer image is never treated as a footer copy because its alt text matches. A `Footer assets` workflow checks on pull requests (offline) that the configured logo files exist, and on push to main, the weekly schedule and manual dispatch sends a real HEAD to both footer logo URLs (`footer --check README.md --online`), failing on any result other than pass.
+- Footer image recognition reads whole attributes: only the exact attribute names `alt`, `src` and `srcset` count, the first occurrence of a name wins even when it has no value (`alt alt="CompleteTech LLC"` reads as an empty alt, so the authored image is preserved), and text inside another attribute's value or a name such as `data-alt` never authorizes an image, so a partner image cannot pass as the footer's logo. No brand or decision change.
+- Own-site footer recognition is limited to the configured historical logo URLs on the company website host (`footer.legacy_logo_urls`), not any file on that host: a team photo or screenshot on the same host stays authored content and is kept through `readme --mode upgrade`. Migrating an unmarked footer reports as removed only the lines the new footer does not emit again, the same multiset rule as marked footers, so a lost banner anchor or other markup is no longer hidden by re-emitted footer lines and fails the never-drop-a-line check. No brand or decision change.
 
 - `doctor` reports disabled-Issues label checks, inapplicable social previews and archived community health as `n/a`, while preserving label coverage during approved archived polishing and unknown captured values on applicable surfaces. Social upload plans share the R10 applicability rule and include the personal-profile capstone.
 - `doctor` reports R11 as `n/a` for archived repositories and outside T1/T2 organizations (personal-account, utility and co-owned repositories), matching the definition of done.
@@ -56,7 +62,7 @@ First public release, for the CompleteTech GitHub estate standard `ct-std-v1`.
 - A T3 org's repository is left out of the personal pins and more projects, other orgs' cross-listings, favorites and star List items until co-owner sign-off (`--allow-t3`), logged `t3-signoff:OWNER/REPO`.
 - `project copy-plan` and the standalone `project readme` name no repository in the README of a board that is public (as captured, approved or not) or may go public (an approved visibility item), logged `readme-links:repositories-omitted (the board may go public)`; a board captured public without approval logs `visibility:public (no approval)`, not `visibility:private`.
 - `labels --plan` and `adopt` refuse an `--org-defaults` metadata JSON or checkout of another org's `.github` (usage, exit 2), with the owner read from `owner`, `owner.login`, `full_name` or the checkout's own `origin` and resolved through the run's org resolver (`--config` included). A JSON without an owner, or a checkout without a GitHub origin, can no longer prove that no default issue form names a label, so the rename stays held (`needs-input:label-references`). Before, another org's `.github` was accepted and the rename was planned while the owner's default forms still assigned the old label.
-- `readme --mode upgrade` (and the bootstrap `edited` path and the preserve list) replace an unmarked or drifted footer at the end of the README with the decision 18 footer instead of appending a second one. Only a block whose every line is a footer line (centring, complete.tech links, the footer's own logo image, the "Built by" credit line) is replaced; an image counts as the footer's logo only when its src or srcset is the brand footer logo URL (or the same file on another branch, with a query, or in its github.com blob/raw form) or its alt is exactly the company, never because its file name contains "logo". A centred block with an authored line (a sponsor or partner image, a thanks line) is kept, so no authored line is dropped. `lint readme` fails `D18 footer fail:duplicate`, and `footer --check` (and doctor's footer column) `fail:duplicate`, when a footer-like block outside code sits before the last block.
+- `readme --mode upgrade` (and the bootstrap `edited` path and the preserve list) replace an unmarked or drifted footer at the end of the README with the decision 18 footer instead of appending a second one. Only a block whose every line is a footer line (centring, links to the configured footer host (`footer.href`), the footer's own logo image, the "Built by" credit line) is replaced; an image counts as the footer's logo only when its src or srcset is the brand footer logo URL (or the same file on another branch, with a query, or in its github.com blob/raw form) or it is a configured historical logo URL on the company website host (`footer.legacy_logo_urls`, not any file on that host) or the conventional local `docs/images/logo.svg` under a company alt, never because its file name contains "logo" or its alt matches. A centred block with an authored line (a sponsor or partner image, a thanks line) is kept, so no authored line is dropped. `lint readme` fails `D18 footer fail:duplicate`, and `footer --check` (and doctor's footer column) `fail:duplicate`, when a footer-like block outside code sits before the last block.
 
 ### Fixed
 

README.md

@@ -189,8 +189,8 @@ Code, templates, and documentation are licensed under the MIT License. CompleteT
 <p align="center">
   <a href="https://www.complete.tech">
     <picture>
-      <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/CompleteTech-LLC/.github/main/brand/logo-dark.png">
-      <img src="https://raw.githubusercontent.com/CompleteTech-LLC/.github/main/brand/logo.png" alt="CompleteTech LLC" width="200">
+      <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/CompleteTech-Skills/github-showcase-skill/main/assets/brand/logo-dark.png">
+      <img src="https://raw.githubusercontent.com/CompleteTech-Skills/github-showcase-skill/main/assets/brand/logo.png" alt="CompleteTech LLC" width="200">
     </picture>
   </a>
   <br>

SKILL.md

@@ -245,7 +245,7 @@ content sidebar --facts FILE [--packages FILE]... [--current FILE] [--repo OWNER
 | `org-banner` | Renders the 1600×400 org profile banner JPG (STANDARD §9.5). | `--out` |
 | `org-tile` | Renders the 400×160 org tile for profile directories. | `--out`, `--png` |
 | `intro` | Renders the profile intro (animated only for the personal profile and T1 flagship orgs; `.still` reduced-motion frame). | `--out` |
-| `footer` | Prints the decision 18 footer between `showcase:footer` markers, or checks that the README ends with it; `--check --online` also HEADs both raw logo URLs and fails (`fail:offline`) unless both return 200 (the Phase 4.0 hard gate). `--org OWNER` answers `exempt`, `exempt:footer` or `hold` for an org outside the footer's scope; for the watching org, `--check` still reads the README (its `.github` gets the footer, and `--org` cannot tell it from a fork). | stdout |
+| `footer` | Prints the decision 18 footer using the published masters in this skill's `assets/brand/`, between `showcase:footer` markers, or checks that the README ends with it; `--check --online` also HEADs both raw logo URLs and fails (`fail:offline`) unless both return 200 (the Phase 4.0 hard gate). `--org OWNER` answers `exempt`, `exempt:footer` or `hold` for an org outside the footer's scope; for the watching org, `--check` still reads the README (its `.github` gets the footer, and `--org` cannot tell it from a fork). | stdout |
 | `readme` | Scaffolds, upgrades or refreshes the header marker blocks; never drops a line (multiset check). `--bootstrap` fills a template body only while its marker's sha256 still matches (a person's edit makes the block theirs). | `README.md` with `--write`; `CONTRIBUTING.md` with `--bootstrap` |
 | `lint` | SVG rules, README rules (R7 plus decisions 13 and 18) and banner PNG checks; `public-leak` checks any public file the run writes against the estate's private set (private slugs and names under every login of the owner, members-only pins, internal notes from the org rows, the registry's top-level notes and judge_changes and the profile's internal keys; OPS-03), reading the private registry and `--meta-dir` only; `prose` runs the CQ-17 checks on text the run writes (§1.2 brand strings, no emoji, no placeholders, the §4.1 formula for descriptions and taglines, typos when the optional `codespell` is installed; `--preserved` text only warns). | nothing |
 | `contact-sheet` | Lays outputs out the way GitHub shows them, on `#0d1117` and `#ffffff` (proofing surfaces, not asset variants). `--org ORG --cross-surface` is the G4 gate: the org avatar at 32 px, a hero banner, a repo card, the social preview and the org banner on one labelled sheet; a missing surface is logged `needs-input:cross-surface:<surface>` (result `incomplete`). | `PATH.on-github-dark.png`, `PATH.on-github-light.png` |

assets/brand/README.md

@@ -4,8 +4,8 @@ The generators read these files through the `brand_assets` paths in `references/
 
 | File | Pixels | Mode | Bytes | sha256 | Source and use |
 |---|---|---|---|---|---|
-| `logo.png` | 2400×1198 | RGB, opaque `#F8FAFC` ground | 243,500 | `a5c3c4ef55336ed4b883d3bc3bb6e1e942b836469bd2b2933bc8cc230b321621` | The current light master, byte-identical to `CompleteTech-LLC/.github/brand/logo.png` and to the Skills `assets/logo.png`. `brand_assets.logo_light`: the full logo on the banner's light card when a repository has no icon and no org mark (the golden look). |
-| `logo-dark.png` | 2400×1198 | RGBA, transparent | 210,785 | `0dc00c0e5159518ff1d552b7052293b4e545ddd35be489e6d114e3ea64db27ec` | The current dark master, byte-identical to `CompleteTech-LLC/.github/brand/logo-dark.png`. `brand_assets.logo_dark`, used on navy surfaces (intro, org tile) while `dark_master: current`. |
+| `logo.png` | 2400×1198 | RGB, opaque `#F8FAFC` ground | 243,500 | `a5c3c4ef55336ed4b883d3bc3bb6e1e942b836469bd2b2933bc8cc230b321621` | The current light master, historically sourced from `CompleteTech-LLC/.github/brand/logo.png`; the footer now uses this published copy because the former URL is missing. `brand_assets.logo_light`: the full logo on the banner's light card when a repository has no icon and no org mark (the golden look). |
+| `logo-dark.png` | 2400×1198 | RGBA, transparent | 210,785 | `0dc00c0e5159518ff1d552b7052293b4e545ddd35be489e6d114e3ea64db27ec` | The current dark master, historically sourced from `CompleteTech-LLC/.github/brand/logo-dark.png`; the footer now uses this published copy because the former URL is missing. `brand_assets.logo_dark`, used on navy surfaces (intro, org tile) while `dark_master: current`. |
 | `logo-dark-full.png` | 1200×599 | RGBA, transparent | 175,690 | `b21ca593975808302f919ca6fab9b10d69866a17c9683d3bff0999a99d7f578e` | The candidate dark master from the complete.tech website's theme (`complete-tech-logo-dark-full.png`), gradient wordmark. `brand_assets.logo_dark_candidate`; selected by setting `dark_master: candidate` once the user confirms decision 19. |
 | `mark-light.png` | 984×643 | RGB, opaque `#F8FAFC` ground | 130,704 | `45a047866068a2c028acbb252f2b9430ecdd3ec3e496b1188867253220f41f78` | The cloud-and-bulb crop (697, 26, 1681, 669) of `logo.png`: the same alpha bounds as the §9.2 `mark-dark.png` box, measured on `logo.png`. `brand_assets.mark_light`: used instead of the full logo in icon boxes under 200 px (the repo card's tile), where the wordmark would be about 3 px tall. Cropped once and committed (never at runtime); a §9.1 rule 2 approval is pending in `state/proposals.md` (set `mark_light: null` to withdraw it). |
 | `mark-dark.png` | — | — | — | — | Not shipped yet. The cloud-and-bulb mark is cropped once by the estate planner, on the chosen dark master, after decision 19 is confirmed. Until it exists, navy surfaces place the full dark logo scaled to fit and log `needs-input:mark-dark`. |

assets/examples/footer-example.md

@@ -2,8 +2,8 @@
 <p align="center">
   <a href="https://www.complete.tech">
     <picture>
-      <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/CompleteTech-LLC/.github/main/brand/logo-dark.png">
-      <img src="https://raw.githubusercontent.com/CompleteTech-LLC/.github/main/brand/logo.png" alt="CompleteTech LLC" width="200">
+      <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/CompleteTech-Skills/github-showcase-skill/main/assets/brand/logo-dark.png">
+      <img src="https://raw.githubusercontent.com/CompleteTech-Skills/github-showcase-skill/main/assets/brand/logo.png" alt="CompleteTech LLC" width="200">
     </picture>
   </a>
   <br>

assets/examples/readme-example.md

@@ -50,8 +50,8 @@ Code and documentation are licensed under the MIT License; see `LICENSE`. Comple
 <p align="center">
   <a href="https://www.complete.tech">
     <picture>
-      <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/CompleteTech-LLC/.github/main/brand/logo-dark.png">
-      <img src="https://raw.githubusercontent.com/CompleteTech-LLC/.github/main/brand/logo.png" alt="CompleteTech LLC" width="200">
+      <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/CompleteTech-Skills/github-showcase-skill/main/assets/brand/logo-dark.png">
+      <img src="https://raw.githubusercontent.com/CompleteTech-Skills/github-showcase-skill/main/assets/brand/logo.png" alt="CompleteTech LLC" width="200">
     </picture>
   </a>
   <br>