Skip to content

Land PR #20 and document the global --allow-t3 #31

Open
0 of 3 issues completed
Open

Description

@CompleteDotTech

Status: Verified during the Pick Your AI rollout (reproduced, or read directly in the code).

Part of epic: Epic: Make co-owner (T3) sign-off auditable and safe.

Summary

PR #20 changes the command surface but touches no documentation. SKILL.md still says --allow-t3 is a meta option.

Evidence

Impact

Users and agents follow stale docs and may think the flag works only on meta.

Proposed fix

Review and merge #20, with docs and a changelog entry in the same or a follow-up PR.

Acceptance criteria

Tasks

Each task below is a sub-issue.

Prior work

Prior work: open PR #20 (opt-in --allow-t3 and the Pick Your AI family), open #7 and PR #13 (variant J badges), merged PRs #14 to #19 (icon art-direction path, UTF-8 output, registry-free org health and label planning, Windows test portability, footer URL repair) and closed issues #8 to #12. Nothing here duplicates those; where an item is already handled it is linked, not refiled.

Fresh VM verification: not run. Findings were verified on a Windows host; hosted CI is separate evidence.

Activity

  1. CompleteDotTech commented on Oct 31, 2026

    @CompleteDotTech
    ContributorAuthor

    Evidence (local, detached worktree at origin/main = f9ec72a8ea124006d004c2982746875071a5319b; no Prior-work duplicate: this issue had no comments)

    PR #20 state: MERGED 2026-10-30T07:51:53Z, merge commit f9ec72a (parent of the change is 2be04ac; base cfc0be5). Read back from gh pr view 20.

    Checks (run through the shared heavy-job lock):

    • python -m unittest discover -s tests -p "test_package_*.py" -v: 23 tests OK (2 skipped)
    • python scripts/validate_package.py: Package contract OK
    • python -m pytest -q: 980 passed, 13 skipped, 37 subtests passed
    • python scripts/validate_quality.py: quality validation ok
    • New test tests/test_allow_t3_global.py: with scripts/ restored to the pre-change parent (2be04ac^) 5 of its 7 tests fail; on f9ec72a all 7 pass.
    • Diff scope 2be04ac^..f9ec72a: 16 files, 252 insertions, 29 deletions; scripts/validate_package.py and tests/test_package_contract.py unchanged. The only added lines with CompleteTech text are brand-config rows and family comparisons.

    Acceptance:

    • Add opt-in T3 showcase support and Pick Your AI identity #20 merged.
    • SKILL.md command reference shows the global flag and its refusals: NOT met. SKILL.md:166 (global options synopsis) has no --allow-t3; it appears only per command (lines 76, 168, 209, 214), and the line 76 and 58 text still frames it around meta. The PR touched none of SKILL.md, ONBOARDING.md, CHANGELOG.md or references/.
    • CHANGELOG lists it under Unreleased: NOT met. The --allow-t3 entries (lines 40, 54) sit under 1.0.0; ## Unreleased has no entry for the global flag.

    The docs must also match the final #28 semantics (sign-off scoped to the invocation, per test_signoff_does_not_outlive_the_invocation). Leaving #31 open; #33 (document the global flag) is the remaining work, #34 (merge) is done.

    Fresh VM verification: not run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/t3-consentCo-owner (T3) sign-off and consent gatesrollout-findingFound while rolling the showcase out to Pick-Your-AI

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions