-
-
Notifications
You must be signed in to change notification settings - Fork 9
Test fixture/POM cleanup #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
590b047
Added Database checks to the onboarding flow
O-Bots d0debad
Added compatibility page setup
O-Bots 543d5e5
Finished up the onboarding flow suite
O-Bots 4293606
.
O-Bots 03d957a
Fix: Merge conflict
O-Bots 5283bec
.
O-Bots f4b1014
Fix: Added fix for None discriptive error issue #36
O-Bots d3bd1cb
Linting and Prettier
O-Bots 45fc0e8
Minor cleaning
MartinBraquet dbca768
Organizing helper func
O-Bots 53c048a
Added Google account to the Onboarding flow
O-Bots bd27bf0
Added account cleanup for google accounts
O-Bots b7057e2
Started work on Sign-in tests
O-Bots b6e0c22
Linting and Prettier
O-Bots 992db24
Added checks to the deleteUser func to check if the accout exists
O-Bots 064bbfb
Linting and Prettier
O-Bots de476bd
Added POM's for social and organisation page
O-Bots 6b1dec0
Formatting update, fixed homePage locator for signin
O-Bots a750776
.
O-Bots e21de93
.
O-Bots 851992b
.
O-Bots c4fc76d
Coderabbitai fix's
O-Bots 615f64d
Fix
MartinBraquet dcd7e06
Improve test utilities and stabilize onboarding flow tests
MartinBraquet bdec007
Changes requested
O-Bots 213757c
Seperated deletion tests from onboarding
O-Bots ada66a2
.
O-Bots 4d2db53
Changed POM/Fixture structure to use an app class to instantiate the …
O-Bots 9fbff67
Apply suggestion from @MartinBraquet
MartinBraquet ebba02c
Apply suggestion from @MartinBraquet
MartinBraquet 071c046
Delete .vscode/settings.json
MartinBraquet 4a452bd
Apply suggestion from @MartinBraquet
MartinBraquet b0b0c9a
Apply suggestions from code review
MartinBraquet 8c78112
Apply suggestion from @MartinBraquet
MartinBraquet b339311
Apply suggestion from @MartinBraquet
MartinBraquet d432f2c
Linting and Prettier
O-Bots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "codium.codeCompletion.enable": false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import { Page } from "@playwright/test"; | ||
| import { UserAccountInformation } from "../utils/accountInformation"; | ||
| import { AuthPage } from "./authPage"; | ||
| import { ComatibilityPage } from "./compatibilityPage"; | ||
| import { HomePage } from "./homePage"; | ||
| import { OnboardingPage } from "./onboardingPage"; | ||
| import { OrganizationPage } from "./organizationPage"; | ||
| import { ProfilePage } from "./profilePage"; | ||
| import { SettingsPage } from "./settingsPage"; | ||
| import { SignUpPage } from "./signUpPage"; | ||
| import { SocialPage } from "./socialPage"; | ||
|
|
||
| export class App { | ||
| readonly auth: AuthPage | ||
| readonly compatibility: ComatibilityPage | ||
| readonly home: HomePage | ||
| readonly onboarding: OnboardingPage | ||
| readonly organization: OrganizationPage | ||
| readonly profile: ProfilePage | ||
| readonly settings: SettingsPage | ||
| readonly signUp: SignUpPage | ||
| readonly social: SocialPage | ||
|
|
||
| constructor(public readonly page: Page) { | ||
| this.auth = new AuthPage(page) | ||
| this.compatibility = new ComatibilityPage(page) | ||
| this.home = new HomePage(page) | ||
| this.onboarding = new OnboardingPage(page) | ||
| this.organization = new OrganizationPage(page) | ||
| this.profile = new ProfilePage(page) | ||
| this.settings = new SettingsPage(page) | ||
| this.signUp = new SignUpPage(page) | ||
| this.social = new SocialPage(page) | ||
| } | ||
|
|
||
| async deleteProfileFromSettings() { | ||
| await this.home.clickSettingsLink() | ||
| await this.settings.clickDeleteAccountButton() | ||
| await this.settings.fillDeleteAccountSurvey('Delete me') | ||
| await this.settings.clickDeleteAccountButton() | ||
| await this.home.verifyHomePageLinks() | ||
| } | ||
|
|
||
| async skipOnboardingHeadToProfile(account: UserAccountInformation) { | ||
| await this.onboarding.clickSkipOnboardingButton() | ||
| await this.signUp.fillDisplayName(account.display_name) | ||
| await this.signUp.fillUsername(account.username) | ||
| await this.signUp.clickNextButton() | ||
| await this.signUp.clickNextButton() | ||
| await this.profile.clickCloseButton() | ||
| await this.onboarding.clickRefineProfileButton() | ||
| } | ||
|
|
||
| async registerWithEmail(account: UserAccountInformation) { | ||
| await this.home.goToRegisterPage() | ||
| await this.auth.fillEmailField(account.email) | ||
| await this.auth.fillPasswordField(account.password) | ||
| await this.auth.clickSignUpWithEmailButton() | ||
| } | ||
|
|
||
| async signinWithEmail( | ||
| accountOrEmail: UserAccountInformation | string, | ||
| password?: string, | ||
| ) { | ||
| const email = typeof accountOrEmail === 'string' ? accountOrEmail : accountOrEmail.email | ||
|
|
||
| const resolvedPassword = typeof accountOrEmail === 'string' ? password : accountOrEmail.password | ||
|
|
||
| if (!email || !resolvedPassword) { | ||
| throw new Error('Provide either an `account` or `email` and `password`.') | ||
| } | ||
|
|
||
| await this.home.goToSigninPage() | ||
| await this.auth.fillEmailField(email) | ||
| await this.auth.fillPasswordField(resolvedPassword) | ||
| await this.auth.clickSignInWithEmailButton() | ||
| } | ||
| } |
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.