Repository navigation
Fix Dimensions -> dimensions in README code samples - #26
Merged
adamsitnik merged 1 commit intoJul 9, 2026
Merged
adamsitnik merged 1 commit into
adamsitnik merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MEVD provider READMEs so the VectorStoreVector attribute’s named constructor argument matches the actual API casing used throughout the codebase (dimensions), avoiding non-compiling documentation samples.
Changes:
- Fix
VectorStoreVectornamed argument fromDimensions:todimensions:in SqlServer README sample. - Fix
VectorStoreVectornamed argument fromDimensions:todimensions:in CosmosNoSql README sample (including the sample that also setsDistanceFunction).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MEVD/src/SqlServer/README.md | Fixes VectorStoreVector named argument casing in the sample model. |
| MEVD/src/CosmosNoSql/README.md | Fixes VectorStoreVector named argument casing in the sample model (with DistanceFunction). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.