camera-ready cleanup: fix hardcoded paths, remove TODOs, replace prin…#3
Open
ComDec wants to merge 1 commit into
Open
camera-ready cleanup: fix hardcoded paths, remove TODOs, replace prin…#3ComDec wants to merge 1 commit into
ComDec wants to merge 1 commit into
Conversation
…ts with logging, auto-version - Replace hardcoded absolute paths in CLI tools (merge_csv_groups, unmerge_logs) with default=None and require --root or --root-glob explicitly - Replace hardcoded checkpoint base path in eval scripts with LOGS_ROOT env var (defaults to ./logs/train), supporting clean override without editing scripts - Remove two stale TODO comments (gfn_utils.py, reward.py) - Delete debug utility script buffer_sample_example.py - Replace bare print() calls in gfn.py and losses.py with logging.warning() - Update setup.py: version auto-generated as 0.1.0+<git-short-sha> https://claude.ai/code/session_011zEp1N46irzpZqjM15vmTP
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ts with logging, auto-version
https://claude.ai/code/session_011zEp1N46irzpZqjM15vmTP