Conversation
- ConditionSQLEncoder.valueToParameterValue: resolve each List element individually instead of passing the whole list to every element. - ConditionEncoder.resolveValueToType: fix single-element Iterable resolution to a primitive type (was a no-op comparison). - MapGetterExtension.matchKeyIgnoreCase: fix case-insensitive key matching that always returned null; also fixes setMultiValue(..., ignoreCase: true). - Time: millisecond/microsecond range now correctly rejects 1000 (0..999). - Time._bytesInStringFormat: fix disabled second-byte digit check. - APISession.isExpired: honor the provided `now` argument. - APIServerResponseCache: fix replaceFileStat self-comparison. - WeakList.set: increment the modification counter. - Tests: added coverage for the bug fixes above. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The `@override` annotation can only be used on class members; remove it from the top-level `resolveFreePort` function (invalid_annotation_target). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 65.93% 66.12% +0.18%
==========================================
Files 63 63
Lines 21221 21222 +1
==========================================
+ Hits 13993 14033 +40
+ Misses 7228 7189 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConditionSQLEncoder.valueToParameterValue: resolve each List element individually instead of passing the whole list to every element.
ConditionEncoder.resolveValueToType: fix single-element Iterable resolution to a primitive type (was a no-op comparison).
MapGetterExtension.matchKeyIgnoreCase: fix case-insensitive key matching that always returned null; also fixes setMultiValue(..., ignoreCase: true).
Time: millisecond/microsecond range now correctly rejects 1000 (0..999).
Time._bytesInStringFormat: fix disabled second-byte digit check.
APISession.isExpired: honor the provided
nowargument.APIServerResponseCache: fix replaceFileStat self-comparison.
WeakList.set: increment the modification counter.
Tests: added coverage for the bug fixes above.