v1.9.29 - Feature: DBEntityRepository.select: allow query ID#142
Merged
Conversation
- `DBEntityRepository`:
- `select`:
- Added optimization for `KeyConditionEQ` matcher with a single key matching the entity ID field.
- When matched, uses `_selectByID` to fetch the entity by ID and returns a single-element list or empty list accordingly.
- Dependency updates:
- `vm_service`: ^15.0.2 → ^15.1.0
gmpassos
changed the title
gmpassos
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 65.75% 65.71% -0.05%
==========================================
Files 63 63
Lines 21198 21216 +18
==========================================
+ Hits 13939 13942 +3
- Misses 7259 7274 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Added method `resolveIDValue` to resolve the ID value from parameters or `ConditionParameter`. - `DBEntityRepository`: - Updated `selectIDsBy` and `_selectByID` to use `ConditionID.resolveIDValue` for ID resolution. - `DBObjectDirectoryAdapter`: - Updated `_doCountImpl` and `_doDeleteImpl` to use `ConditionID.resolveIDValue` for ID resolution. - Updated public methods to pass combined parameters (`parameters ?? namedParameters`) to internal implementations. - `DBObjectGCSAdapter`: - Updated `_doCountImpl` and `_doDeleteImpl` to use `ConditionID.resolveIDValue` for ID resolution. - Updated public methods to pass combined parameters (`parameters ?? namedParameters`) to internal implementations. - `DBObjectMemoryAdapter`: - Updated `_doCountImpl` and `_doDeleteImpl` to use `ConditionID.resolveIDValue` for ID resolution. - Updated public methods to pass combined parameters (`parameters ?? namedParameters`) to internal implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBEntityRepository:select:KeyConditionEQmatcher with a single key matching the entity ID field._selectByIDto fetch the entity by ID and returns a single-element list or empty list accordingly.Dependency updates:
vm_service: ^15.0.2 → ^15.1.0