Conversation
Accept any Docker-compatible engine for act (Podman Desktop preferred) instead of assuming Docker Desktop, and align docs plus environment checks with that policy.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughLocal CI now supports Docker-compatible engines with Podman preferred. Environment checks select and diagnose available engines, ChangesContainer Engine Local CI
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant runAct as run-act.mjs
participant ContainerEngine
participant act
Developer->>runAct: invoke local CI target
runAct->>ContainerEngine: check version and running state
ContainerEngine-->>runAct: return engine status and socket
runAct->>ContainerEngine: pull workflow images
runAct->>act: run workflow with container daemon socket
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/ci-cd.md`:
- Around line 143-146: Update the Mode table’s Command prefix entries to show
complete executable commands, including “pnpm run” for both container and native
examples. Keep the examples consistent with the package scripts and the explicit
commands documented below, including act:ci and act:tests variants.
In `@docs/development-environment.md`:
- Around line 643-647: Update the Windows row in the OS/container-engine table
to state that Podman Desktop must have Docker compatibility enabled, matching
the macOS requirement while preserving the existing Windows installation
commands and links.
In `@scripts/check-environment.mjs`:
- Around line 466-510: Correct the inaccurate policy comment above the
preferred-engine selection: this helper chooses Podman only when podmanOk
indicates its daemon is ready, whereas run-act.mjs selects based on CLI
presence. Update the comment to describe this helper’s daemon-readiness
preference without claiming it matches CONTAINER_ENGINE.
In `@scripts/run-act.mjs`:
- Around line 22-25: Update the CONTAINER_ENGINE selection to verify Podman
readiness with a successful podman info check, rather than relying only on
commandOk('podman', ['--version']); fall back to Docker when Podman is
unavailable or its machine/daemon is not ready.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8ca78c59-b503-4f92-a416-865f83af1b8e
📒 Files selected for processing (8)
AGENTS.mddocs/ci-cd.mddocs/contributing.mddocs/development-environment.mdscripts/check-environment.mjsscripts/check-environment.test.mjsscripts/run-act.mjsscripts/run-act.test.mjs
Fall back to Docker when Podman CLI exists but its daemon is down, and tighten docs/commands from CodeRabbit review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actcontainer CI instead of assuming Docker DesktopAGENTS.md, ci-cd, development-environment, contributing) and install/preflight hints with that policycheck:environmentprefer Podman when both engines are healthy, and report daemon-down vs missing CLI correctlyTest plan
pnpm exec vitest run scripts/check-environment.test.mjs scripts/run-act.test.mjspnpm run check:environmentwith Podman Desktop running (and optionally with Docker Desktop as fallback)pnpm run act:list/ a shortact:*target when a container engine is availablepnpm run act:ci:nativestill works without a container engineSummary by CodeRabbit
Documentation
Improvements
actrunner to use a Docker-compatible container-engine abstraction and generalized messaging.Tests