Repository navigation
Conversation
- 12 OFL caption fonts bundled in assets/fonts with a sha256 manifest and
their licences; video/fonts.py stages them beside the captions file and
adds fontsdir only when a bundled font is used (all eight burn places).
- Caption animations: pop, fade, bounce, karaoke and slide, written as ASS
tags. Karaoke is burned plain for right-to-left languages, and spreads
its fill by word length on a clip that was cut or sped up.
- Safe zones for TikTok, Instagram Reels and YouTube Shorts keep captions
clear of the apps' buttons on vertical clips.
- Six caption presets (config/caption_presets.json) and the caption
controls: preset chips, the font list in two groups, Animation, Safe
zone and an animated example that honours reduced motion.
- GET /fonts, /fonts/{file} and /caption-presets; CSP gains font-src for
the engine.
- With animation none and safe zone off the captions file and the FFmpeg
arguments are unchanged: the existing snapshots and the golden renders
are identical.
Checked: QC and a render review over five rounds (3-D1 to 3-D20 fixed; the
last four by hand and not re-reviewed), black-box S1 to S7, performance and
UX. Not merged; waiting for the owner's click-through.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
The name was built from the process and thread ids in hex, which on Linux is longer than the font's own file name, so the step 3 test for long clip folders failed in CI. It is now 13 characters everywhere. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of the editor suite, stacked on #225 (step 2). Covers the fonts and caption-animation parts of #174.
What's new
What stays the same
With no animation and the safe zone off, the captions file and the FFmpeg arguments are exactly what they were. The existing snapshots are untouched and the golden renders are identical.
How it works
video/fonts.pycopies the fonts a captions file uses into afontsfolder beside it (after a sha256 check) and adds:fontsdir=fontsto the subtitles filter only when a bundled font is used. All eight burn places go through it.GET /fonts,GET /fonts/{file},GET /caption-presets. The page's CSP gainsfont-srcfor the engine.Checks
docs/editor-suite/state.json). The last four were fixed by hand and were not re-reviewed by an independent agent.Known limits
Not for merging yet: waiting for the owner's click-through.
🤖 Generated with Claude Code