Skip to content

fix(i18n): translate UI attributes across components - #217

Merged
ColinGPT9 merged 3 commits into
ColinGPT9:mainfrom
Aaqibhafeezkhan:fix/91-ui-attribute-translations
Nov 5, 2026
Merged

ColinGPT9 merged 3 commits into
ColinGPT9:mainfrom
Aaqibhafeezkhan:fix/91-ui-attribute-translations

Conversation

@Aaqibhafeezkhan

@Aaqibhafeezkhan Aaqibhafeezkhan commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • Migrated hard-coded English placeholder, title and aria-label values in TimelineEditor and the remaining affected UI components and pages.
  • Added the missing t() imports and preserved the original English strings as translation keys.
  • Left URL, path and identifier examples unchanged.
  • Added tests/test_ui_translatable_attributes.py to catch untranslated literal attributes in the migrated components.

The changes use the existing translation function, so available locale entries are applied automatically and missing translations continue to fall back to English.

Closes #91.

@vercel

vercel Bot commented Nov 5, 2026

Copy link
Copy Markdown

@Aaqibhafeezkhan is attempting to deploy a commit to the Clips Studio Team on Vercel.

A member of the Team first needs to authorize it.

@Aaqibhafeezkhan Aaqibhafeezkhan changed the title fix(i18n): translate hard-coded UI attributes fix(i18n): translate UI attributes across components Nov 5, 2026

@Aaqibhafeezkhan Aaqibhafeezkhan left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the UI attribute translations across TimelineEditor and the remaining affected components and pages. Added the missing t() imports and a Python regression test to catch untranslated literal attributes. Preserved URL, path, and identifier examples.

@ColinGPT9

Copy link
Copy Markdown
Owner

I'll check it and merge later I am fixing the video editor to try to make a better one a lot of people were complaining about it in feature request so I am adding features to a new one.

MultilingualExport.tsx and AddVideos.tsx already imported t, so the
added imports were duplicates (TS2300: Duplicate identifier 't').

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ColinGPT9
ColinGPT9 merged commit 2ea80d3 into ColinGPT9:main Nov 5, 2026
9 of 11 checks passed
@ColinGPT9

Copy link
Copy Markdown
Owner

Thanks @Aaqibhafeezkhan, merged! The CI typecheck caught one thing: MultilingualExport.tsx and queue/AddVideos.tsx already imported t, so the two new import lines were duplicates. I removed those two lines on your branch before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some UI text is hard-coded in English and never reaches the translation system

2 participants