Repository navigation
Escape quotes in concat listings, so titles like "I'll" join - #216
Merged
Merged
Conversation
Issue #197: Longform failed every time on a video titled "First Time. Surely I'll be fine. Let's skip the tutorial", with FFmpeg unable to open ".../First Time. Surely Ill". Clip folders are named after the video's title, and every join without re-encoding hands FFmpeg a listing of `file '<path>'` lines. Nothing escaped a quote inside a path, so FFmpeg read each path only up to the apostrophe. Four places wrote those lines: - longform/assemble.py: the job failed (the report). - video/outro.py, append() and finish(): the end card's join failed quietly, so every clip of such a video was made without its card. - sports/core/reels.py: the story reel failed. video/encoding.py concat_entry() now writes each line, closing, escaping and reopening a quote ('\'') as FFmpeg's quoting spells it. A path without a quote is written exactly as before. All four use it, and a test fails if anything else writes a line itself. Checked end to end in a folder named like the reporter's. On main, the end card is skipped (5.00s clip) and Longform fails with #197's error. With this change, the card is added (7.90s) and Longform is made (10.90s). Refs #197 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the cause of #197. Longform failed every time on a video titled "First Time. Surely I'll be fine. Let's skip the tutorial", with FFmpeg unable to open
…/First Time. Surely Ill.Cause
video/encoding.py concat()) hands FFmpeg a listing offile '<path>'lines.Four places wrote those lines:
longform/assemble.pyvideo/outro.py,append()andfinish()sports/core/reels.pyFix
video/encoding.py concat_entry()writes each line. It closes, escapes and reopens a quote ('\''), as FFmpeg's quoting spells it. A path without a quote is written exactly as before.file '{…}'line itself.Checked
End to end, in a folder named like the reporter's. It used a real 1080p60 source and the real end card:
concat join failed … No such file or directory(#197)Tests, in
tests/test_video_join.py; CI runs them, and the real joins skip without FFmpeg:Local runs:
test_outro,test_outro_join,test_video_join,test_sports_reelsandtest_selection_longformall pass in the full environment.newtests, which fail the same way on unchanged main inside a Windows venv.Refs #197
🤖 Generated with Claude Code