Skip to content

[Pick][0.8 to 0.9] | workpool workers join at same time may trigger race condition #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Coldwings wants to merge 1 commit into
base: release/0.9
Choose a base branch
from
Open

[Pick][0.8 to 0.9] | workpool workers join at same time may trigger race condition #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion thread/workerpool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ limitations under the License.

#include <algorithm>
#include <future>
#include <mutex>
#include <random>
#include <thread>
#include <atomic>
Expand Down Expand Up @@ -84,10 +85,16 @@ class WorkPool::impl {
return vcpus.size();
}

// Serialize photon::fini() across workers. When all workers receive
// the shutdown signal simultaneously (via RingChannel), parallel
// vcpu teardown may race on shared state and cause SegFault.
std::mutex fini_mtx;

void worker_thread_routine(int ev_engine, int io_engine) {
photon::init(ev_engine, io_engine);
DEFER(photon::fini());
main_loop();
std::lock_guard<std::mutex> lock(fini_mtx);
photon::fini();
}

void add_vcpu() {
Expand Down