build(medcat): Fix setuptools and vcs versioning#560
Merged
Conversation
Looks like the issue might have come from vcs_versioning instead of directly from setuptools_scm. So the previous PR may not be sufficient
alhendrickson
approved these changes
Jun 23, 2026
mart-r
added a commit
that referenced
this pull request
Jun 23, 2026
* Fix issue with package build from VCS versioning. Looks like the issue might have come from vcs_versioning instead of directly from setuptools_scm. So the previous PR may not be sufficient * Make building verbose in workflow * Stricter restriction for vcs_versioning * Fix verbosity of build process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR actually fixes the issue.
My assumption before was that it was due to
setuptools_scm, but now it's clear it was actuallyvcs_versioning.This time I've actually run this locally to make sure it works! (smart move, I know).
And I've added some verbosity to the builds so I can see what's being installed for building (otherwise it was invisible and therefore it wasn't clear which versions were used when things worked or didn't work).