Cross-platform-audio - #48
Merged
Merged
Conversation
kokoro_engine.py and gui.py unconditionally imported the Windows-only winsound module for preview/JIT playback, forcing the whole app (and CI) onto windows-latest. Add playback.py, a small sounddevice + soundfile wrapper (play/stop), and swap it in at all four call sites: - kokoro_engine.py: cancel()'s SND_PURGE -> playback.stop(), and the JIT playback loop's blocking PlaySound -> playback.play(path, True) - gui.py: the two fire-and-forget preview buttons -> playback.play(path) playback.py degrades to a no-op if sounddevice can't find the system PortAudio library, so machines without libportaudio2 installed don't crash on import. Also: - Add sounddevice to requirements.txt - Repoint conftest.py's engine/real_engine fixtures to mock kokoro_engine.playback instead of kokoro_engine.winsound - Add ubuntu-latest to the CI matrix (installs libportaudio2 for sounddevice, xvfb for the Tk-based GUI tests, runs under xvfb-run) - Update README's testing/CI notes, which had drifted out of date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.