Publish bounded v1 goal and lifecycle contracts - #9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8eb1270d50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "properties": { | ||
| "traceparent": { | ||
| "type": "string", | ||
| "pattern": "^[\\da-f]{2}-[\\da-f]{32}-[\\da-f]{16}-[\\da-f]{2}$" |
There was a problem hiding this comment.
Reject non-compliant traceparent identifiers
For v1 records, this pattern accepts values such as ff-00000000000000000000000000000000-0000000000000000-00, because it only checks lowercase hex lengths. The W3C Trace Context spec forbids version ff and all-zero trace-id/parent-id, so a record can satisfy the v1 schema while compliant downstream tracers must ignore its traceparent.
Useful? React with 👍 / 👎.
| export const schemaRoot = path.join(root, "schemas"); | ||
| export const exampleRoot = path.join(root, "examples"); | ||
| export const schemaDirectory = path.join(schemaRoot, "v0.1"); | ||
| export const exampleDirectory = path.join(exampleRoot, "v0.1"); |
There was a problem hiding this comment.
Include v1 examples in validation
After adding examples/v1.0, npm run validate still imports exampleDirectory and iterates jsonFiles(exampleDirectory), so keeping this export fixed to examples/v0.1 means the documented validation command succeeds without checking any v1.0 fixture. A malformed v1.0 example would be missed unless the user also runs the test suite; point the validation path at exampleRoot with recursive traversal or otherwise cover every versioned example directory.
Useful? React with 👍 / 👎.
Summary\nAdds the bounded v1 goal contract and evidence-backed lifecycle schemas while preserving the existing v0.1 release line.\n\n## Changes\n- Require measurable goal, policy, capability, verification, and budget fields\n- Add bounded execution limits and stop policies\n- Require evidence URIs for verification and evaluation\n- Publish v0.1 and v1.0 registry lines in parallel\n\n## Why\nExecution must reject incomplete or unbounded goals before any model, tool, or worker action.\n\n## Validation\n- 33 contract tests passed\n- Registry build passed\n- Registry validation passed for two releases and two stable lines\n\n## Risks\n- v1 is additive but consumers must explicitly select the new schema line\n- Evidence URI requirements are stricter than v0.1\n\n## Related\nCAS Loop Engineering milestone v1.\n\n## Reviewer notes\nStart with the v1 goal schema and registry immutability tests.