Refactor promotion handling in MCTS logic - #19
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors promotion handling in the MCTS logic by removing redundant code and improving clarity in the promotion value calculation.
- Removes redundant promotion mapping lookup in the MCTS simulation code
- Introduces a temporary variable to store the promotion value for better readability
- Minor formatting adjustment to a comment separator line
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+347
to
+348
| promo_value = PROMOTION_MAP.get(mv.promotion, 0) | ||
| promo_idxs.append(promo_value) |
There was a problem hiding this comment.
The removed line 347 in the original code suggests there was a redundant PROMOTION_MAP.get(mv.promotion, 0) call that wasn't assigned to any variable. The refactor correctly fixes this by storing the result in promo_value and using it, eliminating the wasteful computation.
Owner
Author
There was a problem hiding this comment.
if adequate approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.