fix(unity): restore public build validation - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- restores clean Unity compilation for the public source snapshot\n- keeps rights-clean Song Library tests aligned with the bundled example catalog\n- makes device-capture and onboarding tests follow current runtime contracts\n- suppresses synthetic drum and mistake audio for physical MIDI input, including unmatched hits\n\n## Validation\n\n- Core: 42/42\n- MIDI capture tool: 39/39\n- Unity EditMode: 455/455\n- Unity PlayMode: 46/46\n- .NET builds: 0 warnings, 0 errors\n- NuGet vulnerability audit: passed\n- public-readiness contracts: passed\n- asset provenance contracts: passed\n- macOS signing foundation contracts: passed\n- Windows packaging contracts: passed\n\n## Scope\n\nSource and tests only. No Unity binaries, commercial audio, charts, MIDI content, persistence expansion, scoring, web backend, or AI.