WIP: AST cleanups - #14
Open
ghost wants to merge 5 commits into
Open
Conversation
added 5 commits
October 27, 2021 14:56
This isn't a TypeScript-specific concept, so don't track it in AST.
The type names should be obvious
Rename CallExpression -> CallExpressionDetails Rename Call -> CallExpression (part of Expression enum) Rename decoderExpression to decoderCall, as it's returning a function call in all cases.
Order conceptually, then alphabetically.
The AST grew ad-hoc based on the needs of the backend. This commit restructures it to map more closely to TypeScript itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rearrange the AST to a more regular format that mirrors the actual AST of TypeScript, with a goal of making it easier to read and reason about. Previously some aspects were mirroring how the backend processes data rather than reflecting how TypeScript is actually structured.
This doesn't compile yet, more work would be needed.
Terms