fix: suppress duplicate error output before logging setup#236
Merged
Conversation
pedjaradenkovic
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Following #214, the linked-resource validation error (e.g.
Plain syntax error: Link ... does not exist.) was printed twice during--dry-run— once in plain white text, then again in red.Root cause
console.error()inplain2code_console.pyboth logs the message (logger.error(...)) and rich-prints it in red. On--dry-run(and--status,--full-plain, and early parse errors), the module is parsed beforesetup_logging()configures any handlers. With no handler attached to thecodeplainlogger, Python'slogging.lastResorthandler echoes thelogger.error(...)record to stderr as plain white text — so the same message appears twice (white fromlastResort, red from rich).Fix
Attach a
NullHandlerto thecodeplainlogger at import time (the standard Python library idiom). This suppresseslastResortso records emitted before real handlers exist aren't echoed to stderr, leaving exactly one output on these pre-logging CLI paths. Oncesetup_logging()runs, the real handlers work as before.This also fixes the same latent double-print for any other pre-logging
console.error/console.warningcall (--status,--full-plain).