Write rendered files as UTF-8 to fix Windows UnicodeEncodeError#228
Merged
Conversation
store_response_files opened files with the platform default text codec, which on Windows is cp1252 and cannot encode characters like 📍 (U+1F4CD). LLM-generated content containing such characters crashed the render with UnicodeEncodeError. Specify encoding="utf-8" explicitly, matching how the rest of file_utils reads text. Add a regression test covering unicode content. Fixes CODEPLAIN-P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store_response_files opened files with the platform default text codec, which on Windows is cp1252 and cannot encode characters like 📍 (U+1F4CD). LLM-generated content containing such characters crashed the render with UnicodeEncodeError. Specify encoding="utf-8" explicitly, matching how the rest of file_utils reads text. Add a regression test covering unicode content.
Fixes CODEPLAIN-P
https://codeplain.sentry.io/issues/7563551370/?project=4511540621213696&query=is%3Aunresolved&referrer=issue-stream