Change test run ordering#171
Merged
Merged
Conversation
Contributor
|
That's a very smart change! |
VitjanZ
force-pushed
the
feat/test_run_ordering
branch
from
d336218 to
84129f4
Compare
…onformance test fixing logic.
VitjanZ
force-pushed
the
feat/test_run_ordering
branch
from
0979039 to
575e45e
Compare
zanjonke
approved these changes
May 12, 2026
zanjonke
left a comment
zanjonke
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Left one small comment. I'll test it out locally just to make sure.
Comment on lines
+533
to
+537
| ctx = self.conformance_tests_running_context | ||
|
|
||
| # Get next test to run | ||
| self.conformance_tests_running_context = self._get_next_test_to_run() | ||
|
|
Contributor
There was a problem hiding this comment.
I would flip these 2 lines. At the moment ctx point points to the same object and there is no problem, but in the future if _get_next_test_to_run would create a new object, would be a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing/fixing conformance tests the current testing schedule if the implementation code changes is as such:
This PR changes the ordering to:
This first makes sure the new conformance tests passes and then makes sure that the new code and tests did not cause any regressions.