fix(server): bound provider usage profile errors - #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return one fixed public error for invalid provider-usage profile selectors instead of serializing an exception message across the HTTP boundary.
Security validation
The selector is regex-gated and the current
ValueErrormessages are constants, so the CodeQL finding did not expose a stack trace in the observed implementation. This patch removes the brittle exception-string sink entirely and proves malicious profile text is not reflected.Test Plan
python -m py_compile plugin/relay/server.pyRelease note
This changes the frozen release tree. Android Play preflight will be rerun after merge. PR #419 remains excluded.