You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are the Code Review Comments for the pull request titled "Hospital Management System Oracle APEX":
Title Format: The title should begin with a ClickUp ticket ID followed by a colon, e.g., "86ex6r17g: Hospital Management System Oracle APEX".
Description: The description of the pull request is empty. It should summarize the changes made in this PR.
Indentation: Consistency in indentation is maintained throughout at 4 spaces.
Blank Lines: There are a few unnecessary blank lines across the files:
DDL.sql: Line 3 is an unnecessary blank line; consider removing it.
DML.sql: Line 4 could be removed as well.
Logical Errors:
In DDL.sql, the use of NULL within exception blocks could mask potential errors. It might be better to log or raise an appropriate message.
In DML.sql, the INSERT statements should verify patient_id and doctor_id exist before inserting appointments and admissions. This could prevent foreign key violations.
Potential Improvements:
Consider adding ON DELETE CASCADE for relationships if you want related entries in dependent tables to be removed automatically when a record in the parent table is deleted.
In f104.sql, please check if there are any hardcoded values (like schema names) that may need modification depending on the environment.
All issues and suggestions are relevant to the changes made in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://oracleapex.com/ords/r/alnoormanagmentsystem/alnoor-management-system/login?session=102399443962310