Skip to content

Hospital Managment System Oracle APEX - #602

Merged
KhadijaAlloughai merged 2 commits into
mainfrom
feature/86ey8t2jw/hospital/managment/system
Jul 23, 2026
Merged

Hospital Managment System Oracle APEX#602
KhadijaAlloughai merged 2 commits into
mainfrom
feature/86ey8t2jw/hospital/managment/system

Conversation

@KhadijaAlloughai

@KhadijaAlloughai KhadijaAlloughai commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

@github-actions

Copy link
Copy Markdown

Here are the Code Review Comments for the pull request titled "Hospital Management System Oracle APEX":

  • Title Format: The title should begin with a ClickUp ticket ID followed by a colon, e.g., "86ex6r17g: Hospital Management System Oracle APEX".

  • Description: The description of the pull request is empty. It should summarize the changes made in this PR.

  • Indentation: Consistency in indentation is maintained throughout at 4 spaces.

  • Blank Lines: There are a few unnecessary blank lines across the files:

    • DDL.sql: Line 3 is an unnecessary blank line; consider removing it.
    • DML.sql: Line 4 could be removed as well.
  • Logical Errors:

    • In DDL.sql, the use of NULL within exception blocks could mask potential errors. It might be better to log or raise an appropriate message.

    • In DML.sql, the INSERT statements should verify patient_id and doctor_id exist before inserting appointments and admissions. This could prevent foreign key violations.

  • Potential Improvements:

    • Consider adding ON DELETE CASCADE for relationships if you want related entries in dependent tables to be removed automatically when a record in the parent table is deleted.

    • In f104.sql, please check if there are any hardcoded values (like schema names) that may need modification depending on the environment.

All issues and suggestions are relevant to the changes made in this pull request.

New%20session%20-%202026-07-21T12%3A10%3A00.975Z
opencode session  |  github run

@KhadijaAlloughai
KhadijaAlloughai merged commit f8ae2a2 into main Jul 23, 2026
1 of 2 checks passed
@github-actions

Copy link
Copy Markdown

fatal: could not read Username for 'https://github.com': No such device or address

opencode session  |  github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants