Handled throwables during feed initialization - #1291
Open
girishpanchal30 wants to merge 3 commits into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Plugin build for d88248d is ready 🛎️!
Note You can preview the changes in the Playground |
There was a problem hiding this comment.
Pull request overview
Prevents SimplePie TypeError failures from terminating feed initialization or cron cycles.
Changes:
- Catches
Throwableduring primary and fallback feed initialization. - Continues processing cron jobs after throwable failures.
- Adds structured error logging for initialization failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
includes/admin/feedzy-rss-feeds-import.php |
Broadens cron error handling to all throwables. |
includes/abstract/feedzy-rss-feeds-admin-abstract.php |
Handles and logs SimplePie initialization failures. |
Comments suppressed due to low confidence (2)
includes/abstract/feedzy-rss-feeds-admin-abstract.php:977
- The multi-feed throwable log also omits
$e->getTraceAsString(), so a failed SimplePie initialization does not meet issue #1195’s stack-trace logging acceptance criterion.
'error' => $e->getMessage(),
includes/abstract/feedzy-rss-feeds-admin-abstract.php:1248
- The cloned-feed failure log records only the exception message. Add the throwable trace so fallback initialization failures retain the diagnostic detail required by issue #1195.
'error' => $e->getMessage(),
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+898
to
+900
| try { | ||
| $feed->init(); | ||
| } catch ( \Throwable $e ) { |
| } | ||
| do_action( 'feedzy_run_cron_extra', $job ); | ||
| } catch ( Exception $e ) { | ||
| } catch ( \Throwable $e ) { |
5 tasks
Contributor
|
@girishpanchal30 make sure the checks are passing and no strings are added for this change. |
Contributor
Author
|
@selul I have fixed the string with the latest commit. |
Soare-Robert-Daniel
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved error handling and logging throughout the feed initialization and cron job processes
Check before Pull Request is ready:
Closes #1195