test: enforce exhaustive scenario contracts - #106
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6cb8e9459
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analysis
The existing suite is already broad, with more than 234 syntactically valid transaction scenarios. Literal coverage of every possible PHP program is impossible because the input space is unbounded. The correct production-grade closure is to exhaust the finite contracts the package publishes and to make future changes fail if they add a rule or catalog entry without tests.
The first exhaustive run proved all finite operation catalogs were already correctly detected by the scanner. It exposed one test-coverage gap instead: TG008 had positive mutation scenarios but no explicit negative read-only cache control. That control is now part of the dependency-free scenario matrix.
This PR combines broad scenario testing with completeness meta-tests and data-driven catalog coverage. It runs on the merge-blocking Linux, Windows and macOS matrix introduced in #105.
Scope
Tests, test-support, scenario documentation and changelog only. No analyzer production logic was changed because the exhaustive catalog tests did not expose a scanner implementation gap.