fix: back off after transient HTTP delivery responses - #5
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66e22192f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $root = dirname( __DIR__ ); | ||
| $allow_dirty = in_array( '--allow-dirty', $argv, true ); | ||
| $version = '1.2.1'; | ||
| $version = '1.2.2'; |
There was a problem hiding this comment.
Building this version always fails because scripts/build-release.php passes the generated archive to scripts/verify-package.php, whose lines 81–86 still require the plugin header, constant, and stable tag to be 1.2.1. I confirmed php scripts/build-release.php exits with both version errors, so the package job cannot reach artifact inspection or release.
AGENTS.md reference: AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
| "schema_version": 1, | ||
| "plugin_slug": "codegenie-pulse-connector", | ||
| "plugin_version": "1.2.1", | ||
| "plugin_version": "1.2.2", |
There was a problem hiding this comment.
When composer qa reaches its policy step, scripts/check-repository.php validates this manifest with an unchanged expected version of 1.2.1 at line 77. Running that script against this change exits with WordPress.org asset manifest plugin_version does not match the release, which makes every completed QA matrix fail.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
| gh release create "$TAG" "${assets[@]}" \ | ||
| --repo "$GITHUB_REPOSITORY" \ | ||
| --target "$TAG" \ | ||
| --title "$TAG" \ | ||
| --notes-file docs/releases/1.2.2.md |
There was a problem hiding this comment.
On any push of this commit to main, this job creates and pushes v1.2.2 and then executes gh release create without --draft; gh release create --help states that this form publishes the release after uploading its assets. This turns the generic QA/build workflow into an automatic publishing path instead of leaving tagging and publication as separately authorized maintainer actions.
AGENTS.md reference: AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
| * Plugin Name: Codegenie Pulse Connector | ||
| * Description: Verbind WordPress veilig met Codegenie Pulse voor foutmonitoring, websiteverificatie en deployment tracking. | ||
| * Version: 1.2.1 | ||
| * Version: 1.2.2 |
There was a problem hiding this comment.
The runtime now declares version 1.2.2, but README.md still identifies the plugin, runtime overview, artifact filenames, release notes, workflow input, and tag as 1.2.1. Since the source archive includes that README, consumers and maintainers receive a contradictory public release contract unless it is updated with the rest of the version bump.
AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.
| case 408: | ||
| return __( 'De aanvraag is tijdelijk verlopen. De connector probeert later opnieuw.', 'codegenie-pulse-connector' ); |
There was a problem hiding this comment.
After a 408 response, the rejected event is returned to the caller and discarded; start_backoff() only suppresses subsequent events and there is no queue or scheduled retry. Telling administrators that the connector will try again later is therefore inaccurate, as is the same new wording for 425, and should instead describe the temporary delivery pause.
Useful? React with 👍 / 👎.
1 participant
Summary
Compatibility and privacy
Validation
The existing PHP 7.4, 8.3 and 8.5 source QA, WordPress 6.2 and 7.0 integration matrix, deterministic ZIP build, official Plugin Check and release-contract checks must pass before merge.
WordPress.org
The repository's human-created asset gate remains unchanged. A GitHub release can be published after automated checks, while WordPress.org publication remains blocked until the required approved icons, banners and synthetic screenshots exist.