fix: isolate instance state and complete TypeScript exports - #1
fix: isolate instance state and complete TypeScript exports#1jordyloeuille wants to merge 9 commits into
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 491404fd2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
When a second main-branch push arrives after the first run has pushed its version tag but before its GitHub/npm publication steps finish, this workflow-level setting cancels the first run. The replacement then finds that tag attached to a different SHA in the “Create release tag” step and sets publish=false, leaving that version permanently without a GitHub release and/or npm publication unless someone manually reruns the original workflow. Disable cancellation for main-branch release runs or separate release concurrency from cancellable CI.
Useful? React with 👍 / 👎.
| if [[ ! "$version" =~ ^[0-9]+\.[0-9]+\.[0-9]+([.-][0-9A-Za-z.-]+)?$ ]]; then | ||
| echo "::error::package.json does not contain a valid semantic version: $version" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
When package.json contains a prerelease such as 0.2.0-beta.1, this regex accepts it into the job named “Publish stable release.” The later npm publish invocation supplies no --tag (npm 11's bundled command documentation states that the default tag is latest), and gh release create likewise omits --prerelease, so installing cg-aos without a version can unexpectedly select the beta. Either reject prerelease suffixes here or route them through an npm prerelease dist-tag and GitHub's prerelease flag.
Useful? React with 👍 / 👎.
1 participant
Summary
WeakMapcgAOS.init()calls from inheriting each other'sonceconfigurationindex.d.tsValidation
The PR must pass Node 18 and Node 22 tests, TypeScript checking, the tsup build, production dependency audit and
npm pack --dry-runbefore merge.Release safety
A new tag is only created after the main-branch CI gate succeeds. npm publication is skipped with an explicit workflow warning when
NPM_TOKENis not configured.