Birmingham | MAY 2026 | Ogbemi Mene | Sprint 1 | Form control by meneogbemi42-bit · Pull Request #1294 · CodeYourFuture/Module-Onboarding

meneogbemi42-bit · 2026-05-16T13:23:48Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

on this pull request i created my own form from the beginning with html and css files

netlify · 2026-05-16T13:23:52Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`0d2fafa`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a176162fc25c8000827e639
😎 Deploy Preview	https://deploy-preview-1294--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Luro91

How can you ensure an accessibility score of 100 in lighthouse?

Luro91 · 2026-05-20T04:24:37Z

+    <meta charset="UTF-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <title>T-shirt sales</title>
+    <link rel="stylesheet" href="Untitled-1.css"> 


What else could you use as file name for the stylesheet to adhere more to standard naming?

Did you see this comment?

Luro91 · 2026-05-20T04:25:21Z

+    <link rel="stylesheet" href="Untitled-1.css"> 
+</head>
+
+<body>


Where does the body end?

Luro91 · 2026-05-20T04:25:54Z

I see 3 errors when checking the file in the w3 validator. How can you fix them?

Luro91 · 2026-05-20T04:26:12Z

+
+   <div>
+    <label for="name">NAME</label>
+    <input type="text" name="name" id="name" placeholder="name" value="name" required>


How can you ensure that the name has at least 2 characters?

Luro91 · 2026-05-20T04:27:43Z

+
+        <label for="size">size of T-shirt</label> 
+
+        <select name="size" id="size" required>


The XS option is missing here

…oarding into bbm2

Luro91

How can you achieve a lighthouse score of 100?

Luro91 · 2026-05-25T05:23:22Z

+        <label for="size">size of T-shirt</label> 
+
+        <select name="size" id="size" required>
+            <option value="XS">XS</option>


There is an error in the w3 validator:
Error: The first child option element of a select element with a required attribute, and without a multiple attribute, and without a size attribute whose value is greater than 1, must have either an empty value attribute, or must have no text content. Consider either adding a placeholder option label, or adding a size attribute with a value equal to the number of option elements.

Luro91

Please address the comments from my last review

Luro91 · 2026-05-27T04:42:27Z

Why did you add this new file? untitled-1 is not a clear file name.

i was a mistake i only saved that wrongly on the file folder. it was a practice i did from the practice video from the curriculum.

meneogbemi42-bit · 2026-05-27T07:13:27Z

i have address the last review here, and to pass the w3 validator the can not left empty. hence i left the character choose a colour and select size respectively.

Luro91

How get you get the lighthouse score to 100 in all categories?

Luro91 · 2026-05-27T18:14:15Z

+    <meta charset="UTF-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <title>T-shirt sales</title>
+    <link rel="stylesheet" href="Untitled-1.css"> 


Did you see this comment?

Luro91 · 2026-05-27T18:15:52Z

+   <div>
+    <label for="name">NAME</label>
+    <input type="text" name="name" id="name" placeholder="name" value="name" minlength="2" maxlength="100" required>
+    </div>


The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?

Ogbemi mene added 2 commits May 16, 2026 14:01

my form excesis

bc89d28

my form working

2f98a7b

This comment has been minimized.

Sign in to view

meneogbemi42-bit added 2 commits May 16, 2026 14:33

Change page title to 'T-shirt sales'

c17d258

Add email input and fix label formatting

ad6aa94

This comment has been minimized.

Sign in to view

meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026

Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 20, 2026

Luro91 reviewed May 20, 2026

View reviewed changes

Ogbemi mene added 2 commits May 24, 2026 08:25

my new form for luke

ff30284

Merge branch 'bbm2' of https://github.com/meneogbemi42-bit/Module-Onb…

67dbbd0

…oarding into bbm2

meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 24, 2026

Luro91 reviewed May 25, 2026

View reviewed changes

Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 25, 2026

my new form control

9eb7223

meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 26, 2026

Luro91 reviewed May 27, 2026

View reviewed changes

Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 27, 2026

correction to the last comment

89ac2e4

meneogbemi42-bit removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label May 27, 2026

meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026

removal of the untitled-1.html

d2cfd22

Luro91 reviewed May 27, 2026

View reviewed changes

Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 27, 2026

Ogbemi mene added 4 commits May 27, 2026 21:33

my formated vasion

47042be

my new formated form

fbe384d

new formatted change

9137175

formated code

0d2fafa

meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 27, 2026


		<label for="size">size of T-shirt</label>

		<select name="size" id="size" required>

Uh oh!

Conversation

meneogbemi42-bit commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

netlify Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meneogbemi42-bit commented May 27, 2026

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

meneogbemi42-bit commented May 16, 2026 •

edited

Loading

netlify Bot commented May 16, 2026 •

edited

Loading