Skip to content

Added Member Class Information retrival#112

Open
chrisdedman wants to merge 10 commits into
mainfrom
member-object
Open

Added Member Class Information retrival#112
chrisdedman wants to merge 10 commits into
mainfrom
member-object

Conversation

@chrisdedman

Copy link
Copy Markdown
Contributor

Description

Add a command to retrieve member information and a new Member class to manage member-related functionalities.

close #102

Type of Change

  • Feature
  • Refactor
  • Bug fix
  • Documentation
  • Other: ___

Pre-merge Checklist

  • Run tests: pytest
  • Run type check: mypy
  • Run formatting: black .

@chrisdedman chrisdedman added the feature A new feature label Jul 7, 2026
@chrisdedman chrisdedman self-assigned this Jul 7, 2026
@chrisdedman chrisdedman requested a review from PenguinBoi12 July 7, 2026 22:29

@PenguinBoi12 PenguinBoi12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The foundation of the PR is solid, it's going to be much easier to interact with users. The code in general is clean but there's a few issues with the tests and calls.

Some of those methods are doing request to matrix, like get_displayname, get_profile, etc, but there's not response validation, so if an error happens it's just going to explode. There's a helper in api called matrix_call that helps with that.

There's cases, like profile, where it might change the behaviour, if you still want to return a default value, although maybe it's better to raise (idk), you can try/catch it.

Additionally, your tests don't seem to have those possible failure covered.

Comment thread examples/member.py
Comment thread matrix/member.py Outdated
Comment thread matrix/member.py Outdated
Comment thread matrix/member.py
Comment thread matrix/member.py
Comment thread matrix/member.py
Comment thread matrix/member.py Outdated
@chrisdedman chrisdedman requested a review from PenguinBoi12 July 9, 2026 22:39

@PenguinBoi12 PenguinBoi12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, a few minor thing to update and it's good to go.

Comment thread matrix/member.py Outdated
Comment thread matrix/member.py Outdated
Comment thread matrix/member.py Outdated
…nd improve test cases for profile and permission checks
@chrisdedman chrisdedman requested a review from PenguinBoi12 July 10, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Member Object

2 participants