Drop the Sqlite3Shell CLI driver — SDK-only package#2
Merged
Conversation
The `sqlite3` shell port (`Parser` + `Sqlite3Executable` + its tests) moves to SwiftPorts, where the rest of the CLI layer (the ArgumentParser wrapper + the `sqlite3` executable) already lives. SQLiteKit is now purely the SQLite C library plus its idiomatic Swift glue (the SDK) — one clean responsibility. Removes the `Sqlite3Shell` target + `.library` product + `Sqlite3ShellTests`, and the ShellKit dependency (only the driver used it; the SDK never did). SDK consumers that only depended on the `SQLiteKit` product are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
… scheme iOS coverage is sufficient for the Apple-embedded story, so remove the `build-tvos` and `build-visionos` jobs. Also drop the stale `xcodebuild -scheme Sqlite3Shell` step from `build-ios` — that scheme no longer exists (the shell port moved to SwiftPorts), which is what was failing the iOS job. The kept Apple jobs (macOS / iOS / watchOS) build the SDK against each device SDK; the full suites run on macOS / Linux / Windows / Android. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes SQLiteKit purely the SQLite C library + idiomatic Swift glue (the SDK). The
sqlite3shell port (Parser+Sqlite3Executable+ its tests) moves to SwiftPorts, where the rest of thesqlite3CLI layer already lives.Changes
Sqlite3Shelltarget, its.libraryproduct, andSqlite3ShellTests.ShellKitdependency — only the shell driver used it; the SDK never did.Verification
swift build+swift testgreen (SDK-only; 46 tests).Removing the
Sqlite3Shellproduct is breaking for anything pinned to SQLiteKitmainthat uses it — currently SwiftBash (which is being repointed to SwiftPorts' shell port in its own PR). Part of a coordinated 4-repo change:Sqlite3Shelltarget name collides with this one)Sqlite3Shell; there's a brief window where SwiftBashmainis red between this merge and SwiftBash's)SDK-only consumers that depend only on the
SQLiteKitproduct are unaffected.🤖 Generated with Claude Code