Add the Sqlite3Shell CLI driver as a product#1
Merged
Conversation
The argv parser plus the dot-command / REPL engine that reproduces the sqlite3 command-line shell (`.tables`, `.schema`, `.dump`, `.import`, `.mode`, `-safe`, ...). It is ArgumentParser-free and IO-agnostic — it reads, writes, and authorizes file paths through `ShellKit.Shell` — so a host can drive it in-process on any platform (Android included) and confine it to a sandbox. This is the shell layer that previously lived in SwiftPorts (Sources/SQLiteKit/Sqlite3Shell). Converging it here keeps the SDK and its shell driver in one repo and removes the drift / duplicate-symbol risk of a second copy (Cocoanetics/SwiftPorts#56). SwiftPorts now wraps this product in an ArgumentParser command to ship the `sqlite3` executable; SwiftBash registers it as a native builtin. - New `Sqlite3Shell` library product + target (deps: SQLiteKit, ShellKit core — no ArgumentParser, so no Android module-scanner cycle). - New ShellKit package dependency (pinned to main, like the others). SDK-only consumers of the `SQLiteKit` product never build this target or ShellKit into their link. - Sqlite3ShellTests moved here from SwiftPorts; runs on the full matrix (macOS / Linux / Windows / Android emulator), exercising the port via the ArgumentParser-free `Sqlite3Executable` entry point. - SwiftLint: the faithful CLI port (one dispatch switch, one REPL type) carries scoped `disable:next` directives; `file_length` is allowed as a file-wide disable since it can't be scoped. Verified on macOS: build + 107 tests (default and --traits FTS5,SQLiteVec), swiftlint --strict clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jun 9, 2026
Merged
The iOS Simulator test of `-scheme SQLiteKit` failed with "Scheme
SQLiteKit is not currently configured for the test action" /
"Supported platforms ... is empty".
Root cause: the shell driver pulls in ShellKit -> swift-subprocess, and
swift-subprocess declares `platforms: [.macOS, .iOS("99.0")]` — the
`iOS("99.0")` sentinel means "iOS unsupported". xcodebuild folds
`Sqlite3ShellTests` (transitively -> ShellKit -> Subprocess) into the
autogenerated `SQLiteKit` scheme's test action, so the scheme's iOS
deployment floor becomes 99.0 and its supported-platform set goes empty.
The SDK itself still compiles + tests fine on iOS; only the test-action
scheme resolution breaks. `.swiftpm` is gitignored here, so an explicit
trimmed scheme isn't the project's convention.
Fix: the iOS job now *builds* both `SQLiteKit` and `Sqlite3Shell` for the
iOS device SDK (proving both products compile for iOS — the BUILD action
isn't poisoned) and no longer runs the simulator test. The actual SDK +
shell test suites run on macOS / Linux / Windows / Android via
`swift test` (all green).
Also drop the now-unused `SQLiteKit` dependency + `@testable import` from
`Sqlite3ShellTests` (it references no SQLiteKit symbols directly).
Verified locally: both `xcodebuild build -scheme {SQLiteKit,Sqlite3Shell}
-destination generic/platform=iOS` succeed; `swift test` still 107 green;
swiftlint --strict clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
Sqlite3Shelllibrary product: the argv parser plus thedot-command / REPL engine that reproduces the
sqlite3command-line shell(
.tables,.schema,.dump,.import,.mode,-safe, …). It isArgumentParser-free and IO-agnostic — it reads, writes, and authorizes file
paths through
ShellKit.Shell— so a host can drive it in-process on anyplatform (Android included) and confine it to a sandbox.
Why
This is the shell layer that until now lived in
SwiftPorts (
Sources/SQLiteKit/Sqlite3Shell).The SDK was extracted here first; this brings the shell driver that sits on
top of it into the same repo, so there is a single source of truth and no
second copy to drift — see Cocoanetics/SwiftPorts#56. SwiftPorts now wraps
this product in an ArgumentParser command to ship the
sqlite3executable,and SwiftBash registers it as a native builtin.
Changes
Sqlite3Shelltarget + product (deps:SQLiteKit, ShellKit core —no ArgumentParser, so no Android explicit-module-scanner cycle).
main, like the others). SDK-onlyconsumers of the
SQLiteKitproduct never build this target or ShellKitinto their link.
Sqlite3ShellTestsmoved here from SwiftPorts; exercises the port throughthe ArgumentParser-free
Sqlite3Executableentry point, so it runs on thefull CI matrix (macOS / Linux / Windows / Android emulator).
scoped
disable:nextdirectives at the few oversized declarations;file_lengthis allowed as a file-wide disable since it can't be scoped.Verification
swift build --build-tests+swift testgreen — 107 tests(default), plus the
--traits FTS5,SQLiteVecfiltered suite.swiftlint --strictclean.xcodebuild -scheme Sqlite3Shell -destination generic/platform=iOS→ BUILD SUCCEEDED (
arm64-apple-ios16.0).Merge order
Merge this first. The companion PRs pin this package to
main:SwiftPorts (drops its own
Sqlite3Shell, consumes this product) and SwiftBash(repoints its
sqlite3builtin here).🤖 Generated with Claude Code